Revert change to how expiration timings to calculated. (#403)

gurudesu · Geoffrey Chan · janisz · web-flow · commit 51e30a6b00d8 · 2025-11-26T12:37:16.000+01:00
Co-authored-by: Geoffrey Chan &lt;geoffcha@amazon.com&gt;
Co-authored-by: Tomasz Janiszewski &lt;janiszt@gmail.com&gt;
diff --git a/bigcache_test.go b/bigcache_test.go
@@ -256,7 +256,6 @@ func TestTimingEviction(t *testing.T) {
 	cache.Set("key", []byte("value"))
 
 	// when
-	clock.set(1)
 	cache.Set("key2", []byte("value2"))
 	_, err := cache.Get("key")
 
@@ -1181,7 +1180,7 @@ func TestBigCache_GetWithInfo(t *testing.T) {
 			name:     "Expired",
 			clock:    5,
 			wantData: value,
-			wantResp: Response{},
+			wantResp: Response{EntryStatus: Expired},
 		},
 		{
 			name:     "After Expired",
diff --git a/shard.go b/shard.go
@@ -286,7 +286,7 @@ func (s *cacheShard) isExpired(oldestEntry []byte, currentTimestamp uint64) bool
 	if currentTimestamp <= oldestTimestamp { // if currentTimestamp < oldestTimestamp, the result will out of uint64 limits;
 		return false
 	}
-	return currentTimestamp-oldestTimestamp > s.lifeWindow
+	return currentTimestamp-oldestTimestamp >= s.lifeWindow
 }
 
 func (s *cacheShard) cleanUp(currentTimestamp uint64) {

Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ func (s *cacheShard) isExpired(oldestEntry []byte, currentTimestamp uint64) bool`
`286`	`286`	`if currentTimestamp <= oldestTimestamp { // if currentTimestamp < oldestTimestamp, the result will out of uint64 limits;`
`287`	`287`	`return false`
`288`	`288`	`}`
`289`		`- return currentTimestamp-oldestTimestamp > s.lifeWindow`
	`289`	`+ return currentTimestamp-oldestTimestamp >= s.lifeWindow`
`290`	`290`	`}`
`291`	`291`
`292`	`292`	`func (s *cacheShard) cleanUp(currentTimestamp uint64) {`