Skip to content

Add support to clear-buffer-cache.py for checking SPARK_HOME for slaves #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rnowling wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support to clear-buffer-cache.py for checking SPARK_HOME for slaves #342

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4072c9a
clear-buffer-cache.py assumes the slaves file is located under /root/…
rnowling Jun 25, 2014
bdd2b37
Updated previous commit to clear-buffer-cache.py: cleaned up code, ch…
rnowling Jun 25, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions bin/dev/clear-buffer-cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,22 @@
import os
import thread
import time

machinesFile = "/root/spark-ec2/slaves"
import sys

EC2_MACHINES_FILE = "/root/spark-ec2/slaves"

spark_home = os.getenv("SPARK_HOME")
if spark_home is None:
machinesFile = EC2_MACHINES_FILE
if not os.path.exists(machinesFile):
print "Could not find Spark slaves file. SPARK_HOME is not set and could not find file at %s" % EC2_MACHINES_FILE
sys.exit(1)
else:
machinesFile = spark_home + "/conf/slaves"
if not os.path.exists(machinesFile):
print "Could not find Spark slaves file. Based on SPARK_HOME, expected file to be located at %s" % machinesFile
sys.exit(1)
Copy link

@mattf mattf Jun 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested refactor - lift the test out of the if spark_home is None block, use a generic message


machs = open(machinesFile).readlines()
machs = map(lambda s: s.strip(),machs)
machCount = len(machs)
Expand Down