fixed: SettingWithCopyWarning in failing checks

Author: andrjas

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## [Unreleased]
 
+## [0.11.1] - 2022-02-16
+
+### Fixed
+- SettingWithCopyWarning in failing checks
 ## [0.11.0] - 2022-02-15
 
 ### Added

data_check/output/output.py

@@ -101,6 +101,7 @@ def prepare_pprint_df(
         if self.print_diffed and isinstance(result, DataCheckResult):
             df = get_diffed_df(df, result)
         if "_merge" in df.columns:
+            df = df.copy()
             df["_diff"] = ""
             df.loc[df._merge == "left_only", ["_diff"]] = "db"
             df.loc[df._merge == "right_only", ["_diff"]] = "expected"

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "data_check"
-version = "0.11.0"
+version = "0.11.1"
 description = "simple data validation"
 authors = ["Andreas Rjasanow <andrjas@gmail.com>"]
 license = "MIT"

test/int_test/cli/test_cli.py

@@ -4,6 +4,7 @@
 import shutil
 from os import linesep, sep
 from typing import List, Optional
+import warnings
 
 from data_check.cli.main import main
 
@@ -545,3 +546,11 @@ def test_log_is_written_in_project_path(tmp_path: Path):
 
     log_file = tmp_path / "dc.log"
     assert log_file.exists()
+
+
+def test_failing_prints_no_setting_with_copy_warning():
+    with warnings.catch_warnings(record=True) as record:
+        run(["checks/failing/diff.sql"])
+        for i in record:
+            print(i)
+        assert not record