fix comments

Author: gaozhangmin

bookkeeper-server/src/main/java/org/apache/bookkeeper/discover/ZKRegistrationClient.java

@@ -258,6 +258,21 @@ public CompletableFuture<Versioned<BookieServiceInfo>> getBookieServiceInfo(Book
         }
     }
 
+    private Versioned<BookieServiceInfo> updateWritableBookieInfo(BookieId bookieId, boolean isReadonly,
+                                                                  byte[] bytes, Stat stat)
+            throws IOException {
+        BookieServiceInfo bookieServiceInfo = deserializeBookieServiceInfo(bookieId, bytes);
+        Versioned<BookieServiceInfo> result = new Versioned<>(bookieServiceInfo,
+                new LongVersion(stat.getCversion()));
+        log.info("Update BookieInfoCache (writable bookie) {} -> {}", bookieId, result.getValue());
+        if (isReadonly) {
+            readOnlyBookieInfo.put(bookieId, result);
+        } else {
+            writableBookieInfo.put(bookieId, result);
+        }
+        return result;
+    }
+
     /**
      * Read BookieServiceInfo from ZooKeeper and updates the local cache.
      *
@@ -273,11 +288,8 @@ private CompletableFuture<Versioned<BookieServiceInfo>> readBookieServiceInfoAsy
                 (int rc, String path, Object o, byte[] bytes, Stat stat) -> {
                     if (KeeperException.Code.OK.intValue() == rc) {
                         try {
-                            BookieServiceInfo bookieServiceInfo = deserializeBookieServiceInfo(bookieId, bytes);
-                            Versioned<BookieServiceInfo> result = new Versioned<>(bookieServiceInfo,
-                                    new LongVersion(stat.getCversion()));
-                            log.info("Update BookieInfoCache (writable bookie) {} -> {}", bookieId, result.getValue());
-                            writableBookieInfo.put(bookieId, result);
+                            Versioned<BookieServiceInfo> result =
+                                    updateWritableBookieInfo(bookieId, false, bytes, stat);
                             promise.complete(result);
                         } catch (IOException ex) {
                             log.error("Cannot update BookieInfo for ", ex);
@@ -291,14 +303,8 @@ private CompletableFuture<Versioned<BookieServiceInfo>> readBookieServiceInfoAsy
                                 (int rc2, String path2, Object o2, byte[] bytes2, Stat stat2) -> {
                                     if (KeeperException.Code.OK.intValue() == rc2) {
                                         try {
-                                            BookieServiceInfo bookieServiceInfo =
-                                                    deserializeBookieServiceInfo(bookieId, bytes2);
                                             Versioned<BookieServiceInfo> result =
-                                                    new Versioned<>(bookieServiceInfo,
-                                                            new LongVersion(stat2.getCversion()));
-                                            log.info("Update BookieInfoCache (readonly bookie) {} -> {}",
-                                                    bookieId, result.getValue());
-                                            readOnlyBookieInfo.put(bookieId, result);
+                                                    updateWritableBookieInfo(bookieId, true, bytes, stat);
                                             promise.complete(result);
                                         } catch (IOException ex) {
                                             log.error("Cannot update BookieInfo for ", ex);
@@ -329,18 +335,15 @@ private CompletableFuture<Versioned<BookieServiceInfo>> readBookieInfoAsReadonly
         CompletableFuture<Versioned<BookieServiceInfo>> promise = new CompletableFuture<>();
         // not found, looking for a readonly bookie
         zk.getData(pathAsReadonly, bookieServiceInfoCacheInvalidation,
-                (int rc2, String path2, Object o2, byte[] bytes2, Stat stat2) -> {
-                    if (KeeperException.Code.OK.intValue() == rc2) {
+                (int rc, String path, Object o, byte[] bytes, Stat stat) -> {
+                    if (KeeperException.Code.OK.intValue() == rc) {
                         try {
-                            BookieServiceInfo bookieServiceInfo = deserializeBookieServiceInfo(bookieId, bytes2);
                             Versioned<BookieServiceInfo> result =
-                                    new Versioned<>(bookieServiceInfo, new LongVersion(stat2.getCversion()));
-                            log.info("Update BookieInfoCache (readonly bookie) {} -> {}", bookieId, result.getValue());
-                            readOnlyBookieInfo.put(bookieId, result);
+                                    updateWritableBookieInfo(bookieId, true, bytes, stat);
                             promise.complete(result);
                         } catch (IOException ex) {
                             log.error("Cannot update BookieInfo for ", ex);
-                            promise.completeExceptionally(KeeperException.create(KeeperException.Code.get(rc2), path2)
+                            promise.completeExceptionally(KeeperException.create(KeeperException.Code.get(rc), path)
                                     .initCause(ex));
                             return;
                         }
@@ -360,11 +363,8 @@ private CompletableFuture<Versioned<BookieServiceInfo>> readBookieInfoAsWritable
                 (int rc, String path, Object o, byte[] bytes, Stat stat) -> {
                     if (KeeperException.Code.OK.intValue() == rc) {
                         try {
-                            BookieServiceInfo bookieServiceInfo = deserializeBookieServiceInfo(bookieId, bytes);
-                            Versioned<BookieServiceInfo> result = new Versioned<>(bookieServiceInfo,
-                                    new LongVersion(stat.getCversion()));
-                            log.info("Update BookieInfoCache (writable bookie) {} -> {}", bookieId, result.getValue());
-                            writableBookieInfo.put(bookieId, result);
+                            Versioned<BookieServiceInfo> result =
+                                    updateWritableBookieInfo(bookieId, false, bytes, stat);
                             promise.complete(result);
                         } catch (IOException ex) {
                             log.error("Cannot update BookieInfo for ", ex);