Skip to content

unify the prettier versions#20167

Open
cj-zhukov wants to merge 1 commit intoapache:mainfrom
cj-zhukov:cj-zhukov/unify-the-prettier-versions
Open

unify the prettier versions#20167
cj-zhukov wants to merge 1 commit intoapache:mainfrom
cj-zhukov:cj-zhukov/unify-the-prettier-versions

Conversation

@cj-zhukov
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the development-process Related to development process of DataFusion label Feb 5, 2026
@cj-zhukov
Copy link
Contributor Author

High-level overview

This PR standardizes the Prettier version used across DataFusion’s documentation-related scripts.

During the review, I identified several scripts in both dev/ and ci/ directories that invoked Prettier with different pinned versions. To remove this inconsistency, the scripts were updated to define a local PRETTIER_VERSION variable and use the same Prettier version everywhere.

The chosen approach keeps the solution intentionally simple:

  • no new shared scripts or infrastructure were introduced
  • existing script behavior remains unchanged
  • all Prettier invocations are now aligned to a single version

This provides consistent formatting behavior across local workflows and CI, while keeping the change minimal and easy to review.

As a future improvement, the Prettier version could be centralized (for example, via a shared script or config) if additional tooling versions need to be managed in a similar way. For now, keeping the version local to each script avoids adding new dependencies and keeps the scope focused.

@cj-zhukov
Copy link
Contributor Author

@Jefffrey since you originally pointed this #19750 (comment), it would be great if you could take a look at this PR. Your feedback or any improvements would be much appreciated.

Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we figured a way to unify these, but aligning them is a good first step; perhaps leave the original issue open for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

development-process Related to development process of DataFusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants