Skip to content

[refine](expr)Check the column returned after each expression execution.#60569

Open
Mryange wants to merge 3 commits intoapache:masterfrom
Mryange:add-expr-exec-check
Open

[refine](expr)Check the column returned after each expression execution.#60569
Mryange wants to merge 3 commits intoapache:masterfrom
Mryange:add-expr-exec-check

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Feb 6, 2026

What problem does this PR solve?

After every call to execute_column, verify that the returned column is valid.
This PR also adds const to the Selector* selector parameter.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Feb 6, 2026

run buildall

@Mryange
Copy link
Contributor Author

Mryange commented Feb 6, 2026

run buildall

1 similar comment
@Mryange
Copy link
Contributor Author

Mryange commented Feb 6, 2026

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30451 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e4c3ff81cbe1092ed083dd2a767eaaa5d6dffad4, data reload: false

------ Round 1 ----------------------------------
q1	17629	4498	4323	4323
q2	2031	399	243	243
q3	10114	1326	752	752
q4	10194	799	324	324
q5	7526	2239	1987	1987
q6	201	183	152	152
q7	881	746	625	625
q8	9279	1417	1189	1189
q9	4820	4633	4664	4633
q10	6821	1924	1558	1558
q11	519	304	295	295
q12	367	376	228	228
q13	17770	4108	3207	3207
q14	232	242	221	221
q15	897	802	818	802
q16	681	673	615	615
q17	702	868	538	538
q18	6532	5771	5652	5652
q19	1101	1015	631	631
q20	502	485	386	386
q21	2596	1828	1801	1801
q22	365	322	289	289
Total cold run time: 101760 ms
Total hot run time: 30451 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4407	4379	4384	4379
q2	272	348	252	252
q3	2110	2659	2245	2245
q4	1338	1778	1290	1290
q5	4413	4135	4322	4135
q6	225	180	140	140
q7	1834	1816	1637	1637
q8	2502	2724	2464	2464
q9	7651	7498	7525	7498
q10	2818	3148	2592	2592
q11	564	482	456	456
q12	659	749	607	607
q13	3910	4501	3531	3531
q14	312	327	322	322
q15	887	858	834	834
q16	680	723	698	698
q17	1154	1347	1415	1347
q18	8093	8037	8016	8016
q19	950	944	970	944
q20	2144	2154	1954	1954
q21	4886	4466	4347	4347
q22	585	598	553	553
Total cold run time: 52394 ms
Total hot run time: 50241 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.38 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e4c3ff81cbe1092ed083dd2a767eaaa5d6dffad4, data reload: false

query1	0.05	0.04	0.04
query2	0.10	0.04	0.04
query3	0.26	0.08	0.08
query4	1.60	0.11	0.11
query5	0.27	0.25	0.25
query6	1.16	0.67	0.67
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.56	0.50	0.48
query10	0.55	0.56	0.55
query11	0.15	0.10	0.09
query12	0.14	0.11	0.11
query13	0.63	0.61	0.63
query14	1.06	1.04	1.05
query15	0.87	0.86	0.87
query16	0.40	0.39	0.42
query17	1.14	1.10	1.16
query18	0.22	0.21	0.22
query19	2.06	1.95	1.98
query20	0.02	0.02	0.01
query21	15.40	0.25	0.14
query22	5.24	0.06	0.05
query23	16.09	0.30	0.10
query24	1.87	0.40	0.66
query25	0.08	0.06	0.09
query26	0.15	0.13	0.14
query27	0.06	0.09	0.06
query28	4.85	1.14	0.97
query29	12.56	3.97	3.21
query30	0.28	0.14	0.12
query31	2.82	0.65	0.42
query32	3.23	0.62	0.49
query33	3.21	3.30	3.26
query34	16.02	5.39	4.76
query35	4.81	4.80	4.69
query36	0.65	0.50	0.48
query37	0.11	0.07	0.08
query38	0.07	0.04	0.05
query39	0.04	0.03	0.03
query40	0.19	0.16	0.15
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 99.24 s
Total hot run time: 28.38 s

@Mryange
Copy link
Contributor Author

Mryange commented Feb 7, 2026

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 30184 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ea68e5a9b449d01a4e5c9906b964b4579f1f7e77, data reload: false

------ Round 1 ----------------------------------
q1	17628	4400	4301	4301
q2	2007	353	236	236
q3	10175	1317	717	717
q4	10199	784	317	317
q5	7537	2250	1901	1901
q6	198	179	145	145
q7	888	749	630	630
q8	9272	1367	1114	1114
q9	4815	4634	4540	4540
q10	6861	1947	1553	1553
q11	528	297	275	275
q12	401	376	219	219
q13	17802	4082	3234	3234
q14	251	239	219	219
q15	890	808	811	808
q16	684	673	634	634
q17	702	810	539	539
q18	6478	5734	5727	5727
q19	1504	983	604	604
q20	507	488	372	372
q21	2570	1871	1814	1814
q22	363	326	285	285
Total cold run time: 102260 ms
Total hot run time: 30184 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4437	4367	4359	4359
q2	257	339	254	254
q3	2101	2687	2191	2191
q4	1349	1737	1289	1289
q5	4275	4239	4174	4174
q6	226	177	134	134
q7	1864	1772	1678	1678
q8	2519	2678	2531	2531
q9	7588	7533	7521	7521
q10	2875	3095	2560	2560
q11	539	509	453	453
q12	727	772	595	595
q13	3911	4530	3852	3852
q14	344	322	290	290
q15	874	813	806	806
q16	856	710	670	670
q17	1156	1378	1405	1378
q18	8247	8182	7802	7802
q19	910	878	853	853
q20	2036	2313	1974	1974
q21	4898	4755	4324	4324
q22	581	533	488	488
Total cold run time: 52570 ms
Total hot run time: 50176 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.37 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ea68e5a9b449d01a4e5c9906b964b4579f1f7e77, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.04	0.04
query3	0.25	0.09	0.08
query4	1.61	0.11	0.11
query5	0.28	0.25	0.24
query6	1.17	0.67	0.66
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.56	0.49	0.49
query10	0.55	0.54	0.54
query11	0.13	0.09	0.09
query12	0.14	0.11	0.10
query13	0.65	0.61	0.62
query14	1.05	1.06	1.07
query15	0.89	0.87	0.86
query16	0.40	0.38	0.38
query17	1.15	1.13	1.10
query18	0.22	0.21	0.21
query19	2.01	1.96	2.02
query20	0.02	0.02	0.01
query21	15.39	0.26	0.16
query22	5.01	0.07	0.06
query23	15.74	0.28	0.10
query24	1.51	0.63	0.50
query25	0.13	0.08	0.06
query26	0.14	0.13	0.13
query27	0.07	0.08	0.05
query28	5.08	1.13	0.96
query29	12.55	3.84	3.14
query30	0.28	0.12	0.11
query31	2.82	0.63	0.39
query32	3.23	0.60	0.48
query33	3.26	3.22	3.24
query34	16.40	5.36	4.73
query35	4.76	4.78	4.76
query36	0.66	0.49	0.49
query37	0.11	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.20	0.16	0.15
query41	0.09	0.04	0.03
query42	0.04	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 98.92 s
Total hot run time: 28.37 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 34.00% (17/50) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.53% (19371/36873)
Line Coverage 36.06% (180215/499789)
Region Coverage 32.41% (139738/431136)
Branch Coverage 33.44% (60519/181002)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 84.00% (42/50) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.72% (25917/36136)
Line Coverage 54.33% (270875/498561)
Region Coverage 51.75% (225392/435522)
Branch Coverage 53.24% (96743/181710)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants