FINERACT-2457: Share transaction chronological validation incorrectly blocks new transactions based on rejected/reversed transactions

Author: wkigenyi

fineract-provider/src/main/java/org/apache/fineract/portfolio/shareaccounts/serialization/ShareAccountDataSerializer.java

@@ -708,7 +708,7 @@ public Map<String, Object> validateAndApplyAddtionalShares(JsonCommand jsonComma
         boolean isTransactionBeforeExistingTransactions = false;
         Set<ShareAccountTransaction> transactions = account.getShareAccountTransactions();
         for (ShareAccountTransaction transaction : transactions) {
-            if (!transaction.isChargeTransaction()) {
+            if (!transaction.isChargeTransaction() && transaction.isActive()) {
                 LocalDate transactionDate = transaction.getPurchasedDate();
                 if (DateUtils.isBefore(requestedDate, transactionDate)) {
                     isTransactionBeforeExistingTransactions = true;
@@ -1020,7 +1020,7 @@ public Map<String, Object> validateAndClose(JsonCommand jsonCommand, ShareAccoun
         boolean isTransactionBeforeExistingTransactions = false;
         Set<ShareAccountTransaction> transactions = account.getShareAccountTransactions();
         for (ShareAccountTransaction transaction : transactions) {
-            if (!transaction.isChargeTransaction()) {
+            if (!transaction.isChargeTransaction() && transaction.isActive()) {
                 LocalDate transactionDate = transaction.getPurchasedDate();
                 if (DateUtils.isBefore(closedDate, transactionDate)) {
                     isTransactionBeforeExistingTransactions = true;