feat: new deckgl and maplibre plugins#38035
Open
birkskyum wants to merge 15 commits intoapache:masterfrom
Open
feat: new deckgl and maplibre plugins#38035birkskyum wants to merge 15 commits intoapache:masterfrom
birkskyum wants to merge 15 commits intoapache:masterfrom
Conversation
Contributor
|
Bito Automatic Review Skipped - Large PR |
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #38035 +/- ##
===========================================
+ Coverage 0 66.62% +66.62%
===========================================
Files 0 671 +671
Lines 0 51729 +51729
Branches 0 5792 +5792
===========================================
+ Hits 0 34462 +34462
- Misses 0 15876 +15876
- Partials 0 1391 +1391
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
superset-frontend/plugins/plugin-chart-maplibre/src/components/ScatterPlotOverlay.tsx
Show resolved
Hide resolved
superset-frontend/plugins/preset-chart-deckgl/src/CategoricalDeckGLContainer.tsx
Show resolved
Hide resolved
superset-frontend/plugins/preset-chart-deckgl/src/CategoricalDeckGLContainer.tsx
Show resolved
Hide resolved
superset-frontend/plugins/preset-chart-deckgl/src/components/Legend.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/preset-chart-deckgl/src/layers/Screengrid/controlPanel.ts
Show resolved
Hide resolved
superset-frontend/plugins/preset-chart-deckgl/src/layers/utils/metricUtils.ts
Show resolved
Hide resolved
superset-frontend/plugins/preset-chart-deckgl/src/utilities/HandlebarsRenderer.tsx
Show resolved
Hide resolved
superset-frontend/plugins/preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx
Show resolved
Hide resolved
superset-frontend/plugins/preset-chart-deckgl/src/utilities/controlRegistry.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #30307
Summary
Implements SIP-130 — migrate map visualizations from proprietary Mapbox GL to open-source MapLibre GL JS.
Two new plugins:
preset-chart-deckgl— All 11 deck.gl chart types on deck.gl 9 + MapLibre (keys:deck_*_maplibre)plugin-chart-maplibre— Scatter/cluster chart replacing legacy MapBox (key:maplibre)Legacy plugins unchanged — existing dashboards keep working with original keys (
deck_arc,deck_scatter, etc.).They follow the new plugin style and will be the successors of the:
Changes
Frontend
react-map-glv8 +MapboxOverlay/useControlpattern (replaces v6StaticMap)MainPreset.tsBackend
viz.py:MapLibreViz+ 11Deck*Maplibreviz subclassesconfig.py: CSPconnect-srcsimplified tohttps:for tile provider flexibilityBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
A new feature:
Ability to runtime set the map style, by selecting from drop down or by inserting a url:
Requested #30307 (comment) by @StarkillerGDN.
The styles requested have to be whitelisted here:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION