Skip to content

Commit 499aa2a

Browse files
committed
Upgrading commons-text and java-uuid-generator
1 parent ad823fe commit 499aa2a

File tree

3 files changed

+20
-28
lines changed
  • core
    • persistence-jpa/src/test/java/org/apache/syncope/core/persistence/jpa/inner
    • persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner

3 files changed

+20
-28
lines changed

core/persistence-jpa/src/test/java/org/apache/syncope/core/persistence/jpa/inner/UserTest.java

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,16 @@
1818
*/
1919
package org.apache.syncope.core.persistence.jpa.inner;
2020

21-
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
2221
import static org.junit.jupiter.api.Assertions.assertEquals;
2322
import static org.junit.jupiter.api.Assertions.assertFalse;
2423
import static org.junit.jupiter.api.Assertions.assertNotNull;
2524
import static org.junit.jupiter.api.Assertions.assertNull;
2625
import static org.junit.jupiter.api.Assertions.assertThrows;
2726
import static org.junit.jupiter.api.Assertions.assertTrue;
27+
import static org.junit.jupiter.api.Assertions.fail;
2828

29-
import java.security.InvalidKeyException;
30-
import java.security.NoSuchAlgorithmException;
3129
import java.time.OffsetDateTime;
3230
import java.util.List;
33-
import javax.crypto.BadPaddingException;
34-
import javax.crypto.IllegalBlockSizeException;
35-
import javax.crypto.NoSuchPaddingException;
3631
import org.apache.syncope.common.lib.types.CipherAlgorithm;
3732
import org.apache.syncope.core.persistence.api.EncryptorManager;
3833
import org.apache.syncope.core.persistence.api.dao.DerSchemaDAO;
@@ -261,9 +256,7 @@ public void issueSYNCOPE1666() {
261256
}
262257

263258
@Test
264-
public void issueSYNCOPE1937()
265-
throws NoSuchPaddingException, IllegalBlockSizeException, NoSuchAlgorithmException, BadPaddingException,
266-
InvalidKeyException {
259+
public void issueSYNCOPE1937() throws Exception {
267260
User user = entityFactory.newEntity(User.class);
268261
user.setUsername("username");
269262
user.setRealm(realmDAO.getRoot());
@@ -273,7 +266,8 @@ public void issueSYNCOPE1937()
273266
user.setCipherAlgorithm(CipherAlgorithm.SHA1);
274267
user.setPassword("password123");
275268

276-
User actual = userDAO.save(user);
269+
user = userDAO.save(user);
270+
assertNotNull(user);
277271

278272
assertEquals(0, user.getPasswordHistory().size());
279273

@@ -292,8 +286,10 @@ public void issueSYNCOPE1937()
292286
assertEquals(3, user.getPasswordHistory().size());
293287

294288
// try with an exceeding number
295-
assertDoesNotThrow(() -> user.removeOldestEntriesFromPasswordHistory(user.getPasswordHistory().size() + 5));
296-
297-
assertNotNull(actual);
289+
try {
290+
user.removeOldestEntriesFromPasswordHistory(user.getPasswordHistory().size() + 5);
291+
} catch (Exception e) {
292+
fail(e);
293+
}
298294
}
299295
}

core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/UserTest.java

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,16 @@
1818
*/
1919
package org.apache.syncope.core.persistence.neo4j.inner;
2020

21-
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
2221
import static org.junit.jupiter.api.Assertions.assertEquals;
2322
import static org.junit.jupiter.api.Assertions.assertFalse;
2423
import static org.junit.jupiter.api.Assertions.assertNotNull;
2524
import static org.junit.jupiter.api.Assertions.assertNull;
2625
import static org.junit.jupiter.api.Assertions.assertThrows;
2726
import static org.junit.jupiter.api.Assertions.assertTrue;
27+
import static org.junit.jupiter.api.Assertions.fail;
2828

29-
import java.security.InvalidKeyException;
30-
import java.security.NoSuchAlgorithmException;
3129
import java.time.OffsetDateTime;
3230
import java.util.List;
33-
import javax.crypto.BadPaddingException;
34-
import javax.crypto.IllegalBlockSizeException;
35-
import javax.crypto.NoSuchPaddingException;
3631
import org.apache.syncope.common.lib.types.CipherAlgorithm;
3732
import org.apache.syncope.core.persistence.api.EncryptorManager;
3833
import org.apache.syncope.core.persistence.api.dao.DerSchemaDAO;
@@ -261,9 +256,7 @@ public void issueSYNCOPE1666() {
261256
}
262257

263258
@Test
264-
public void issueSYNCOPE1937()
265-
throws NoSuchPaddingException, IllegalBlockSizeException, NoSuchAlgorithmException, BadPaddingException,
266-
InvalidKeyException {
259+
public void issueSYNCOPE1937() throws Exception {
267260
User user = entityFactory.newEntity(User.class);
268261
user.setUsername("username");
269262
user.setRealm(realmDAO.getRoot());
@@ -273,7 +266,8 @@ public void issueSYNCOPE1937()
273266
user.setCipherAlgorithm(CipherAlgorithm.SHA1);
274267
user.setPassword("password123");
275268

276-
User actual = userDAO.save(user);
269+
user = userDAO.save(user);
270+
assertNotNull(user);
277271

278272
assertEquals(0, user.getPasswordHistory().size());
279273

@@ -292,8 +286,10 @@ public void issueSYNCOPE1937()
292286
assertEquals(3, user.getPasswordHistory().size());
293287

294288
// try with an exceeding number
295-
assertDoesNotThrow(() -> user.removeOldestEntriesFromPasswordHistory(user.getPasswordHistory().size() + 5));
296-
297-
assertNotNull(actual);
289+
try {
290+
user.removeOldestEntriesFromPasswordHistory(user.getPasswordHistory().size() + 5);
291+
} catch (Exception e) {
292+
fail(e);
293+
}
298294
}
299295
}

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,7 @@ under the License.
459459

460460
<commons-lang3.version>3.20.0</commons-lang3.version>
461461
<commons-jexl.version>3.6.0</commons-jexl.version>
462-
<commons-text.version>1.14.0</commons-text.version>
462+
<commons-text.version>1.15.0</commons-text.version>
463463

464464
<pac4j.version>6.1.1</pac4j.version>
465465

@@ -681,7 +681,7 @@ under the License.
681681
<dependency>
682682
<groupId>com.fasterxml.uuid</groupId>
683683
<artifactId>java-uuid-generator</artifactId>
684-
<version>5.1.1</version>
684+
<version>5.2.0</version>
685685
</dependency>
686686

687687
<dependency>

0 commit comments

Comments
 (0)