FIX ISSUE #640 (#641)

* Removed the i band 

Removed the i band conversion that should never exists in ZTF

* fix error on the check of per point per band

* Update tests to match the fix

* Update tests to match the fix

* Fix hard coded min duration

---------

Co-authored-by: Etienne Russeil <etru7215@localhost.localdomain>

Author: erusseil

fink_science/ztf/superluminous/kernel.py

@@ -24,5 +24,5 @@
 bolometric = "bazin"
 min_points_total = 7
 min_points_perband = 3
-min_duration = 20
+min_duration = 30
 not_sl_threshold = -19.75

fink_science/ztf/superluminous/processor.py

@@ -124,7 +124,7 @@ def superluminous_score(
         # Initialise all probas to -1
         probas_total = np.zeros(len(objectId), dtype=float) - 1
         transient_mask = pdf["is_transient"]
-        old_enough_mask = pdf["jd"] - pdf["jdstarthist"] >= 30
+        old_enough_mask = pdf["jd"] - pdf["jdstarthist"] >= kern.min_duration
         mask_valid = transient_mask & old_enough_mask
 
         if sum(mask_valid) == 0:

fink_science/ztf/superluminous/slsn_classifier.py

@@ -580,9 +580,9 @@ def extract_features(data):
 
     # Only the fake alert should pass the cuts
     >>> np.testing.assert_equal(
-    ... np.array(np.sum(full_features.iloc[:30].isnull(), axis=1)),
-    ... np.array([ 0,  0,  0,  0,  0,  0,  0,  29,  0,  0,  0,  0,  0,
-    ... 0,  0,  0,  0,  0,  0,  0,  0,  0, 29, 29, 29,  0, 29, 29, 29, 29]))
+    ... np.array(np.sum(full_features.iloc[-30:].isnull(), axis=1)),
+    ... np.array([ 29, 29, 29,  29, 29, 29,  29, 29, 29,  29, 29, 29,  29,
+    ... 29, 29, 29,  29, 29, 29,  29, 29, 29, 29, 29, 29,  29, 29, 29, 29, 0]))
 
     >>> list(full_features.columns) == ["distnr", "ra", "dec", "ebv", "duration",
     ... "flux_amplitude", "kurtosis", "max_slope", "skew", "peak_mag", "std_flux", "q15",