-
-
Notifications
You must be signed in to change notification settings - Fork 112
Description
This issue is an overview to point to the existing and future PRs that address a variety of issues and improvements that are on my current fork.
I hope that most or all of the individual PRs can be incorporated so that I can switch to using the next release of this library rather than maintaining so many differences on my own fork.
I will mention this issue in each relevant PR as I create them but it is likely that some of the earlier PRs will need to be decided upon before every PR can be created, to avoid complicated merge conflicts, etc.
https://github.com/kee-org/biometric_storage/tree/keevault-2025
This branch shows the full set of commits I am hoping to incorporate (except the final commit which is necessary only for local debugging on my physical iOS device). The other build related commit was necessary to get the app to build and install on my system, so I assume they will now also be required for everyone but perhaps it is somewhat dependant upon Xcode or global Dart/Java versions - feel free to cherrypick them straight away and ask me to rebase any of the pending PRs if you find they are already needed in your test environment.
All the changes are based on the approach I've been running in production for a few years but I have yet to roll out the exact commits here - e.g. several of the behaviours are now configurable and I have rebased upon the latest code in this repo. I'll be working on that integration in the coming weeks but hopefully each change is simple enough that any glaring errors are already visible through code review alone.