From f3d7b65196c9901bb136893ef4944434924c9e84 Mon Sep 17 00:00:00 2001 From: zeroflaw Date: Wed, 20 Oct 2021 22:08:23 +0100 Subject: [PATCH 1/3] save macos keys in keychain under app.bundle.id --- macos/Classes/BiometricStorageImpl.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/macos/Classes/BiometricStorageImpl.swift b/macos/Classes/BiometricStorageImpl.swift index a2c79d3..eea1648 100644 --- a/macos/Classes/BiometricStorageImpl.swift +++ b/macos/Classes/BiometricStorageImpl.swift @@ -51,7 +51,7 @@ class BiometricStorageImpl { private func baseQuery(name: String) -> [String: Any] { return [kSecClass as String: kSecClassGenericPassword, - kSecAttrService as String: "flutter_biometric_storage", + kSecAttrService as String: Bundle.main.bundleIdentifier, kSecAttrAccount as String: name] } From 7755c33b04252a0e98628d0dc67817b8bcb1dea8 Mon Sep 17 00:00:00 2001 From: zeroflaw Date: Wed, 20 Oct 2021 22:25:25 +0100 Subject: [PATCH 2/3] silence the warning --- macos/Classes/BiometricStorageImpl.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/macos/Classes/BiometricStorageImpl.swift b/macos/Classes/BiometricStorageImpl.swift index eea1648..2d35a47 100644 --- a/macos/Classes/BiometricStorageImpl.swift +++ b/macos/Classes/BiometricStorageImpl.swift @@ -51,7 +51,7 @@ class BiometricStorageImpl { private func baseQuery(name: String) -> [String: Any] { return [kSecClass as String: kSecClassGenericPassword, - kSecAttrService as String: Bundle.main.bundleIdentifier, + kSecAttrService as String: Bundle.main.bundleIdentifier as Any, kSecAttrAccount as String: name] } From d4347ef9f1d9f00d7cb25df1d5807ceffde14729 Mon Sep 17 00:00:00 2001 From: zeroflaw <37941815+zeroflaw@users.noreply.github.com> Date: Fri, 10 Dec 2021 14:19:45 +0000 Subject: [PATCH 3/3] disable win32 --- pubspec.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pubspec.yaml b/pubspec.yaml index 44bba86..581d3aa 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -47,8 +47,8 @@ flutter: pluginClass: BiometricStoragePlugin windows: # TODO I don't think this is supported yet https://github.com/flutter/flutter/issues/52267 - dartPluginClass: Win32BiometricStoragePlugin - fileName: biometric_storage_win32.dart + #dartPluginClass: Win32BiometricStoragePlugin + #fileName: biometric_storage_win32.dart pluginClass: none web: pluginClass: BiometricStoragePluginWeb