Footgun: Silent Data Loss on S3 Cleanup Failures

[kitzy]

Potential Footgun

Location: Lines 1483-1491 in FleetImporter/FleetImporter.py

Issue: Cleanup failures are logged but don't propagate errors, so users won't know when retention policies fail.

except ClientError as e:
    self.output(f"Warning: S3 cleanup failed: {e}")
except Exception as e:
    self.output(f"Warning: S3 cleanup failed: {e}")

Impact:

• Unexpected S3 costs from accumulating old versions
• Users assume cleanup worked when it didn't
• No visibility into why cleanup failed
• Silent failures can accumulate over time

Recommended Fix:

1. Make cleanup errors more visible (ERROR level, not warning)
2. Optionally fail the workflow if cleanup fails
3. Add configuration option for strict vs. lenient cleanup behavior
4. Track and report cleanup statistics

Priority: Medium - Can lead to unexpected costs