-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
enhancementNew feature or requestNew feature or requestfootgunPotential footgun or unexpected behaviorPotential footgun or unexpected behaviorgood first issueGood for newcomersGood for newcomersmedium-priorityMedium priority issueMedium priority issue
Description
Potential Footgun
Location: Line 1858 in FleetImporter/FleetImporter.py
Issue: Hardcoded assumption that all repos use main branch - will fail for repos using master or custom default branches.
"base": "main", # TODO: Make this configurableImpact:
- PR creation failures for repos not using
main - Workflow breaks without clear error message
- Cannot support organizations with different branching strategies
Recommended Fix:
- Make base branch configurable via input parameter
- Detect default branch via GitHub API:
# Get default branch from repo
repo_info = self._make_github_request(
"GET",
f"/repos/{owner}/{repo}",
github_token
)
default_branch = repo_info.get("default_branch", "main")- Fall back to
mainonly if detection fails
Configuration Option:
Input = {
"base_branch": {
"required": False,
"description": "Base branch for PRs (default: auto-detect)",
},
}Priority: Medium - Affects repos with non-standard branching
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestfootgunPotential footgun or unexpected behaviorPotential footgun or unexpected behaviorgood first issueGood for newcomersGood for newcomersmedium-priorityMedium priority issueMedium priority issue