Skip to content

Commit c95fe59

Browse files
authored
Move things in docs/release-notes to reflect reality (which was enforced by wrong technical mapping) (dotnet#19234)
* Merge FCS 11.0.0 release notes into 10.0.200, reset 11.0.0 to empty template * Add 10.0.300.md empty template files for FSharp.Compiler.Service and FSharp.Core * Change release notes action to be driven by an env var
1 parent 422667d commit c95fe59

File tree

6 files changed

+59
-61
lines changed

6 files changed

+59
-61
lines changed

.github/workflows/check_release_notes.yml

Lines changed: 16 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -50,39 +50,27 @@ jobs:
5050
5151
echo "Opt out of release notes: $OPT_OUT_RELEASE_NOTES"
5252
53-
# Parse version from eng/Versions.props
54-
# For FSarp.Core:
55-
# <FSMajorVersion>8</FSMajorVersion>
56-
# <FSMinorVersion>0</FSMinorVersion>
57-
# <FSBuildVersion>100</FSBuildVersion>
58-
# For FCS:
59-
# FCSMajorVersion>43</FCSMajorVersion>
60-
# <FCSMinorVersion>8</FCSMinorVersion>
61-
# <FCSBuildVersion>$(FSBuildVersion)</FCSBuildVersion>
62-
# For VS:
63-
# <VSMajorVersion>17</VSMajorVersion>
64-
# <VSMinorVersion>8</VSMinorVersion>
53+
# VNEXT is a GitHub repository variable set via admin settings
54+
# It controls the expected release notes version for FSharp.Core and FCS
55+
VNEXT="${{ vars.VNEXT }}"
56+
if [[ -z "$VNEXT" ]]; then
57+
echo "Error: VNEXT repository variable is not set. Please configure it in GitHub repository settings."
58+
exit 1
59+
fi
6560
66-
_fs_major_version=$(grep -oPm1 "(?<=<FSMajorVersion>)[^<]+" eng/Versions.props)
67-
_fs_minor_version=$(grep -oPm1 "(?<=<FSMinorVersion>)[^<]+" eng/Versions.props)
68-
_fs_build_version=$(grep -oPm1 "(?<=<FSBuildVersion>)[^<]+" eng/Versions.props)
69-
_fcs_major_version=$(grep -oPm1 "(?<=<FCSMajorVersion>)[^<]+" eng/Versions.props)
70-
_fcs_minor_version=$(grep -oPm1 "(?<=<FCSMinorVersion>)[^<]+" eng/Versions.props)
71-
_fcs_build_version=$_fs_build_version
61+
# Parse VS major version from eng/Versions.props for the vNext pattern
62+
# <VSMajorVersion>18</VSMajorVersion>
7263
_vs_major_version=$(grep -oPm1 "(?<=<VSMajorVersion>)[^<]+" eng/Versions.props)
73-
_vs_minor_version=$(grep -oPm1 "(?<=<VSMinorVersion>)[^<]+" eng/Versions.props)
7464
75-
FSHARP_CORE_VERSION="$_fs_major_version.$_fs_minor_version.$_fs_build_version"
76-
FCS_VERSION="$_fcs_major_version.$_fcs_minor_version.$_fcs_build_version"
77-
VISUAL_STUDIO_VERSION="$_vs_major_version.$_vs_minor_version"
65+
FSHARP_CORE_VERSION="$VNEXT"
66+
FCS_VERSION="$VNEXT"
67+
VISUAL_STUDIO_VERSION="$_vs_major_version.vNext"
7868
79-
echo "Found F# version: ${FSHARP_CORE_VERSION}"
80-
echo "Found FCS version: ${FCS_VERSION}"
81-
echo "Found Visual Studio version: ${VISUAL_STUDIO_VERSION}"
69+
echo "Using VNEXT for release notes: ${VNEXT}"
70+
echo "Visual Studio release notes: ${VISUAL_STUDIO_VERSION}"
8271
83-
[[ "$FSHARP_CORE_VERSION" =~ ^[0-9]+\.[0-9]+.[0-9]+$ ]] || (echo " Invalid FSharp.Core Version parsed"; exit 1)
84-
[[ "$FCS_VERSION" =~ ^[0-9]+\.[0-9]+.[0-9]+$ ]] || (echo " Invalid FCS Version parsed"; exit 1)
85-
[[ "$VISUAL_STUDIO_VERSION" =~ ^[0-9]+\.[0-9]+$ ]] || (echo " Invalid Visual Studio Version parsed"; exit 1)
72+
[[ "$VNEXT" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]] || (echo " Invalid VNEXT format (expected X.Y.Z)"; exit 1)
73+
[[ "$_vs_major_version" =~ ^[0-9]+$ ]] || (echo " Invalid VS major version parsed"; exit 1)
8674
8775
_release_notes_base_path='docs/release-notes'
8876
_fsharp_core_release_notes_path="${_release_notes_base_path}/.FSharp.Core/${FSHARP_CORE_VERSION}.md"

docs/release-notes/.FSharp.Compiler.Service/10.0.200.md

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,38 @@
88
* Fixed runtime crash when using interfaces with unimplemented static abstract members as constrained type arguments. ([Issue #19184](https://github.com/dotnet/fsharp/issues/19184))
99
* Fix delegates with `[<OptionalArgument>]` and caller info attributes failing to compile. ([Issue #18868](https://github.com/dotnet/fsharp/issues/18868), [PR #19069](https://github.com/dotnet/fsharp/pull/19069))
1010
* Type checker: mark generated event tree nodes as synthetic ([PR #19213](https://github.com/dotnet/fsharp/pull/19213))
11+
* Nullness: Fix nullness refinement in match expressions to correctly narrow type to non-null after matching null case. ([Issue #18488](https://github.com/dotnet/fsharp/issues/18488), [PR #18852](https://github.com/dotnet/fsharp/pull/18852))
12+
* Scripts: Fix resolving the dotnet host path when an SDK directory is specified. ([PR #18960](https://github.com/dotnet/fsharp/pull/18960))
13+
* Fix excessive StackGuard thread jumping ([PR #18971](https://github.com/dotnet/fsharp/pull/18971))
14+
* Adjust conservative method-overload duplicate detection rules for nativeptr types ([PR #18911](https://github.com/dotnet/fsharp/pull/18911))
15+
* Checking: Fix checking nested fields for records and anonymous ([PR #18964](https://github.com/dotnet/fsharp/pull/18964))
16+
* Fix name is bound multiple times is not reported in 'as' pattern ([PR #18984](https://github.com/dotnet/fsharp/pull/18984))
17+
* Syntax Tree: fix return type info for let! / and! / use! ([PR #19004](https://github.com/dotnet/fsharp/pull/19004))
18+
* Fix: warn FS0049 on upper union case label. ([PR #19003](https://github.com/dotnet/fsharp/pull/19003))
19+
* Type relations cache: handle potentially "infinite" types ([PR #19010](https://github.com/dotnet/fsharp/pull/19010))
20+
* Disallow recursive structs with lifted type parameters ([Issue #18993](https://github.com/dotnet/fsharp/issues/18993), [PR #19031](https://github.com/dotnet/fsharp/pull/19031))
21+
* Fix units-of-measure changes not invalidating incremental builds. ([Issue #19049](https://github.com/dotnet/fsharp/issues/19049))
22+
* Fix race in graph checking of type extensions. ([PR #19062](https://github.com/dotnet/fsharp/pull/19062))
23+
* Type relations cache: handle unsolved type variables ([Issue #19037](https://github.com/dotnet/fsharp/issues/19037)) ([PR #19040](https://github.com/dotnet/fsharp/pull/19040))
24+
* Fix insertion context for modules with multiline attributes. ([Issue #18671](https://github.com/dotnet/fsharp/issues/18671))
25+
* Fix `--typecheck-only` for scripts stopping after processing `#load`-ed script ([PR #19048](https://github.com/dotnet/fsharp/pull/19048))
26+
* Fix object expressions in struct types generating invalid IL with byref fields causing TypeLoadException at runtime. ([Issue #19068](https://github.com/dotnet/fsharp/issues/19068), [PR #19070](https://github.com/dotnet/fsharp/pull/19070))
1127

1228
### Added
1329

1430
* Detect and error on static extension members extending types with the same simple name but different namespaces in the same module. ([PR #18821](https://github.com/dotnet/fsharp/pull/18821))
1531
* FSharpDiagnostic: add default severity ([#19152](https://github.com/dotnet/fsharp/pull/19152))
1632
* Add warning FS3879 for XML documentation comments not positioned as first non-whitespace on line. ([PR #18891](https://github.com/dotnet/fsharp/pull/18891))
17-
* FsiEvaluationSession.ParseAndCheckInteraction: add keepAssemblyContents optional parameter ([#19155](https://github.com/dotnet/fsharp/pull/19155))
33+
* FsiEvaluationSession.ParseAndCheckInteraction: add keepAssemblyContents optional parameter ([#19155](https://github.com/dotnet/fsharp/pull/19155))
34+
* Add FSharpCodeCompletionOptions ([PR #19030](https://github.com/dotnet/fsharp/pull/19030))
35+
* Type checker: recover on checking binding parameter constraints ([#19046](https://github.com/dotnet/fsharp/pull/19046))
36+
* Debugger: provide breakpoint ranges for short lambdas ([#19067](https://github.com/dotnet/fsharp/pull/19067))
37+
* Add support for triple quoted ASCII byte string ([#19182](https://github.com/dotnet/fsharp/pull/19182))
38+
39+
### Changed
40+
41+
* Parallel compilation features: ref resolution, graph based checking, ILXGen and optimization enabled by default ([PR #18998](https://github.com/dotnet/fsharp/pull/18998))
42+
* Make graph based type checking and parallel optimizations deterministic ([PR #19028](https://github.com/dotnet/fsharp/pull/19028))
1843

1944
### Breaking Changes
2045

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
### Fixed
2+
3+
### Added
4+
5+
### Changed
6+
7+
### Breaking Changes

docs/release-notes/.FSharp.Compiler.Service/11.0.0.md

Lines changed: 0 additions & 32 deletions
This file was deleted.
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
### Fixed
2+
3+
### Added
4+
5+
### Changed
6+
7+
### Breaking Changes
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
### Fixed
2+
3+
### Changed

0 commit comments

Comments
 (0)