Omit AccessDenied and InvalidClientTokenId errors from private schema faults (#400)

Author: Zee2413

src/schema/GetSchemaTask.ts

@@ -99,6 +99,12 @@ export class GetPrivateSchemasTask extends GetSchemaTask {
             this.logger.info(`${schemas.length} private schemas retrieved`);
         } catch (error) {
             const { category, httpStatus } = classifyAwsError(error);
+
+            if (category === 'permissions' || category === 'credentials') {
+                this.logger.info(`Skipping private schemas due to ${category} issue`);
+                return;
+            }
+
             this.telemetry.count('getSchemas.error', 1, {
                 attributes: { category, httpStatus },
             });

src/utils/AwsErrorMapper.ts

@@ -75,7 +75,7 @@ export function classifyAwsError(error: unknown): { category: AwsErrorCategory;
     if (isNetworkError(error)) {
         return { category: 'network', httpStatus };
     }
-    if (error.name === 'AccessDeniedException' || httpStatus === 403) {
+    if (error.name === 'AccessDeniedException' || error.name === 'AccessDenied' || httpStatus === 403) {
         return { category: 'permissions', httpStatus };
     }
     if (error.name === 'ThrottlingException' || httpStatus === 429) {

tst/unit/schema/GetSchemaTask.test.ts

@@ -128,5 +128,21 @@ describe('GetSchemaTask', () => {
 
             await expect(task.run(mockDataStore)).rejects.toThrow('Schema retrieval failed');
         });
+
+        it('should handle permission errors gracefully without throwing', async () => {
+            const error = { name: 'AccessDenied', $metadata: { httpStatusCode: 403 } };
+            const mockGetSchemas = vi.fn().mockRejectedValue(error);
+            const task = new GetPrivateSchemasTask(mockGetSchemas);
+
+            await expect(task.run(mockDataStore)).resolves.not.toThrow();
+        });
+
+        it('should handle credential errors gracefully without throwing', async () => {
+            const error = { name: 'InvalidClientTokenId', $metadata: { httpStatusCode: 403 } };
+            const mockGetSchemas = vi.fn().mockRejectedValue(error);
+            const task = new GetPrivateSchemasTask(mockGetSchemas);
+
+            await expect(task.run(mockDataStore)).resolves.not.toThrow();
+        });
     });
 });

tst/unit/utils/AwsErrorMapper.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect } from 'vitest';
 import { ErrorCodes, ResponseError } from 'vscode-languageserver';
-import { mapAwsErrorToLspError } from '../../../src/utils/AwsErrorMapper';
+import { classifyAwsError, mapAwsErrorToLspError } from '../../../src/utils/AwsErrorMapper';
 import { OnlineFeatureErrorCode } from '../../../src/utils/OnlineFeatureError';
 
 describe('mapAwsErrorToLspError', () => {
@@ -69,3 +69,17 @@ describe('mapAwsErrorToLspError', () => {
         expect(result.message).toContain('Unknown error');
     });
 });
+
+describe('classifyAwsError', () => {
+    it('should classify AccessDenied as permissions', () => {
+        const error = { name: 'AccessDenied', $metadata: { httpStatusCode: 403 } };
+        const result = classifyAwsError(error);
+        expect(result.category).toBe('permissions');
+    });
+
+    it('should classify AccessDeniedException as permissions', () => {
+        const error = { name: 'AccessDeniedException', $metadata: { httpStatusCode: 403 } };
+        const result = classifyAwsError(error);
+        expect(result.category).toBe('permissions');
+    });
+});