Fix some code quality issues identified by LGTM (#925)

Author: awschristou

src/credentials/providers/sharedCredentialsProvider.ts

@@ -112,11 +112,10 @@ export class SharedCredentialsProvider implements CredentialsProvider {
     private validateSourceProfileChain(): string | undefined {
         const profilesTraversed: string[] = [this.profileName]
 
-        let profileName = this.profileName
         let profile = this.profile
 
         while (!!profile[SHARED_CREDENTIAL_PROPERTIES.SOURCE_PROFILE]) {
-            profileName = profile[SHARED_CREDENTIAL_PROPERTIES.SOURCE_PROFILE]!
+            const profileName = profile[SHARED_CREDENTIAL_PROPERTIES.SOURCE_PROFILE]!
 
             // Cycle
             if (profilesTraversed.indexOf(profileName) !== -1) {

src/eventSchemas/commands/downloadSchemaItemCode.ts

@@ -173,9 +173,7 @@ export class SchemaCodeDownloader {
 }
 
 export class CodeGenerator {
-    public constructor(public client: SchemaClient) {
-        this.client = client
-    }
+    public constructor(public client: SchemaClient) {}
 
     public async generate(
         codeDownloadRequest: SchemaCodeDownloadRequestDetails
@@ -210,9 +208,7 @@ export class CodeGenerator {
 }
 
 export class CodeGenerationStatusPoller {
-    public constructor(public client: SchemaClient) {
-        this.client = client
-    }
+    public constructor(public client: SchemaClient) {}
 
     public async pollForCompletion(
         codeDownloadRequest: SchemaCodeDownloadRequestDetails,
@@ -258,9 +254,7 @@ export class CodeGenerationStatusPoller {
     }
 }
 export class CodeDownloader {
-    public constructor(public client: SchemaClient) {
-        this.client = client
-    }
+    public constructor(public client: SchemaClient) {}
 
     public async download(codeDownloadRequest: SchemaCodeDownloadRequestDetails): Promise<ArrayBuffer> {
         const response = await this.client.getCodeBindingSource(

src/shared/filesystemUtilities.ts

@@ -62,12 +62,11 @@ export async function findFileInParentPaths(searchFolder: string, fileToFind: st
 }
 
 export const makeTemporaryToolkitFolder = async (...relativePathParts: string[]) => {
-    const _relativePathParts = relativePathParts || []
-    if (_relativePathParts.length === 0) {
-        _relativePathParts.push('vsctk')
+    if (relativePathParts.length === 0) {
+        relativePathParts.push('vsctk')
     }
 
-    const tmpPath = path.join(tempDirPath, ..._relativePathParts)
+    const tmpPath = path.join(tempDirPath, ...relativePathParts)
     const tmpPathParent = path.dirname(tmpPath)
     // fs.makeTemporaryToolkitFolder fails on OSX if prefix contains path separator
     // so we must create intermediate dirs if needed