add unit test and use globals setInterval

Author: Zee2413

packages/core/src/awsService/cloudformation/stacks/actions/changeSetDeletionWorkflow.ts

@@ -17,19 +17,18 @@ import { createChangeSetDeletionParams } from './stackActionUtil'
 import { getLogger } from '../../../../shared/logger/logger'
 import { commandKey, extractErrorMessage } from '../../utils'
 import { commands } from 'vscode'
+import globals from '../../../../shared/extensionGlobals'
 
 export class ChangeSetDeletion {
     private readonly id: string
-    private readonly stackName: string
-    private readonly changeSetName: string
-    private readonly client: LanguageClient
     private status: StackActionPhase | undefined
 
-    constructor(stackName: string, changeSetName: string, client: LanguageClient) {
+    constructor(
+        private readonly stackName: string,
+        private readonly changeSetName: string,
+        private readonly client: LanguageClient
+    ) {
         this.id = uuidv4()
-        this.stackName = stackName
-        this.changeSetName = changeSetName
-        this.client = client
     }
 
     async delete() {
@@ -39,7 +38,7 @@ export class ChangeSetDeletion {
     }
 
     private pollForProgress() {
-        const interval = setInterval(() => {
+        const interval = globals.clock.setInterval(() => {
             getChangeSetDeletionStatus(this.client, { id: this.id })
                 .then(async (deletionResult) => {
                     if (deletionResult.phase === this.status) {
@@ -68,7 +67,7 @@ export class ChangeSetDeletion {
                                 )
                             }
                             void commands.executeCommand(commandKey('stacks.refresh'))
-                            clearInterval(interval)
+                            globals.clock.clearInterval(interval)
                             break
                         case StackActionPhase.DELETION_FAILED: {
                             const describeDeplomentStatusResult = await describeChangeSetDeletionStatus(this.client, {
@@ -80,15 +79,16 @@ export class ChangeSetDeletion {
                                 describeDeplomentStatusResult.FailureReason ?? 'No failure reason provided'
                             )
                             void commands.executeCommand(commandKey('stacks.refresh'))
-                            clearInterval(interval)
+                            globals.clock.clearInterval(interval)
                             break
                         }
                     }
                 })
                 .catch(async (error) => {
                     getLogger().error(`Error polling for deletion status: ${error}`)
                     showErrorMessage(`Error polling for deletion status: ${extractErrorMessage(error)}`)
-                    clearInterval(interval)
+                    void commands.executeCommand(commandKey('stacks.refresh'))
+                    globals.clock.clearInterval(interval)
                 })
         }, 1000)
     }

packages/core/src/test/awsService/cloudformation/stacks/actions/changeSetDeletionWorkflow.test.ts

@@ -0,0 +1,85 @@
+/*!
+ * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import assert from 'assert'
+import { SinonSandbox, SinonStub, createSandbox } from 'sinon'
+import { commands } from 'vscode'
+import { ChangeSetDeletion } from '../../../../../awsService/cloudformation/stacks/actions/changeSetDeletionWorkflow'
+import {
+    StackActionPhase,
+    StackActionState,
+} from '../../../../../awsService/cloudformation/stacks/actions/stackActionRequestType'
+import { commandKey } from '../../../../../awsService/cloudformation/utils'
+import { globals } from '../../../../../shared'
+
+describe('ChangeSetDeletion', function () {
+    let sandbox: SinonSandbox
+
+    beforeEach(function () {
+        sandbox = createSandbox()
+    })
+
+    afterEach(function () {
+        sandbox.restore()
+    })
+
+    describe('delete', function () {
+        let mockClient: any
+        let executeCommandStub: SinonStub
+        let getChangeSetDeletionStatusStub: SinonStub
+        let describeChangeSetDeletionStatusStub: SinonStub
+        let setIntervalStub: SinonStub
+
+        beforeEach(function () {
+            mockClient = { sendRequest: sandbox.stub().resolves({}) }
+            executeCommandStub = sandbox.stub(commands, 'executeCommand').resolves()
+
+            const stackActionApi = require('../../../../../awsService/cloudformation/stacks/actions/stackActionApi')
+            getChangeSetDeletionStatusStub = sandbox.stub(stackActionApi, 'getChangeSetDeletionStatus')
+            describeChangeSetDeletionStatusStub = sandbox.stub(stackActionApi, 'describeChangeSetDeletionStatus')
+            sandbox.stub(stackActionApi, 'deleteChangeSet').resolves()
+
+            setIntervalStub = sandbox.stub(globals.clock, 'setInterval').callsFake((callback: () => void) => {
+                setImmediate(() => callback())
+                return 1 as any
+            })
+            sandbox.stub(globals.clock, 'clearInterval')
+        })
+
+        it('should call refresh command after successful deletion', async function () {
+            getChangeSetDeletionStatusStub.resolves({
+                phase: StackActionPhase.DELETION_COMPLETE,
+                state: StackActionState.SUCCESSFUL,
+            })
+
+            const deletion = new ChangeSetDeletion('test-stack', 'test-changeset', mockClient)
+            await deletion.delete()
+            await new Promise((resolve) => setImmediate(resolve))
+
+            assert.ok(executeCommandStub.calledWith(commandKey('stacks.refresh')))
+        })
+
+        it('should call refresh command after failed deletion', async function () {
+            getChangeSetDeletionStatusStub.resolves({ phase: StackActionPhase.DELETION_FAILED })
+            describeChangeSetDeletionStatusStub.resolves({ FailureReason: 'Test failure' })
+
+            const deletion = new ChangeSetDeletion('test-stack', 'test-changeset', mockClient)
+            await deletion.delete()
+            await new Promise((resolve) => setImmediate(resolve))
+
+            assert.ok(executeCommandStub.calledWith(commandKey('stacks.refresh')))
+        })
+
+        it('should not call refresh command when polling encounters error', async function () {
+            getChangeSetDeletionStatusStub.rejects(new Error('Polling error'))
+
+            const deletion = new ChangeSetDeletion('test-stack', 'test-changeset', mockClient)
+            await deletion.delete()
+            await new Promise((resolve) => setImmediate(resolve))
+
+            assert.ok(executeCommandStub.calledWith(commandKey('stacks.refresh')))
+        })
+    })
+})