Settings show even if not in use

[laryn]

When adding a new field, all the Maxlength settings show even if maxlength is not intended to be used on the field. Maybe it would be cleaner to add a checkbox indicating you want to use maxlength, then display the settings? (Manualcrop does this, for example)

[laryn]

[yorkshire-pudding]

@laryn Yes please. - I came to this issue queue to suggest such a thing.

Should include all the fields highlighted in the image in first post; your latter image seems to leave the countdown message setting still visible.

[yorkshire-pudding]

@laryn - was the image a mockup or does some draft code exist?

[laryn]

@yorkshire-pudding It was just a mockup created in browser.

The mentioned example, however, does very similar in Manual Crop:

• https://github.com/backdrop-contrib/manualcrop/blob/1.x-1.x/manualcrop.admin.inc#L665-L671

[yorkshire-pudding]

I thought this might be quick and easy so had a little look at this, but struggled with determining what the initial value should be for sites that already have the module; I tried to determine it based on whether the maxlength_js field was greater than zero but couldn't figure out the best way.

[laryn]

I think that seems reasonable -- automatically having the box checked to display settings if the maxlength_js field has a value.