Bug: Model "name" does not affect value show in model selector fields #1663
Closed
arcanemachine
started this conversation in
General
Replies: 1 comment
-
|
Oh, I just found the original model name code now. I'm an idiot. Whoops! |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
The model docs indicate that a model's "name" (if present) should override the "id" value when using the model selector.
However, this feature is not currently working in the current master.
I have added a pull request here that fixes the issue, and adds a couple tests to prevent regressions.
The feature could not be tested without modifying the production code, which has been modified (as little as possible) to use a getter function which generates the name to be displayed (uses model "name" if present, or fallback to "id").
P.S. It seems that the issue tracker is closed at the moment? Hopefully this is a good place to leave this message.
Beta Was this translation helpful? Give feedback.
All reactions