refactor(tests): remove example functions and improve path handling in tests

Author: bartventer

store/fscache/filenamer_test.go

@@ -16,30 +16,13 @@ package fscache
 
 import (
 	"encoding/base64"
-	"fmt"
 	"path/filepath"
 	"strings"
 	"testing"
 
 	"github.com/bartventer/httpcache/internal/testutil"
 )
 
-func Example_fragmentFileName_short() {
-	url := "https://short.url/test"
-	path := fragmentFileName(url)
-	fmt.Println("Fragmented path:", path)
-	// Output:
-	// Fragmented path: aHR0cHM6Ly9zaG9ydC51cmwvdGVzdA
-}
-
-func Example_fragmentFileName_long() {
-	url := "https://example.com/" + strings.Repeat("a", 255)
-	path := fragmentFileName(url)
-	fmt.Println("Fragmented path:", path)
-	// Output:
-	// Fragmented path: aHR0cHM6Ly9leGFtcGxlLmNvbS9hYWFhYWFhYWFhYWFhYWFh/YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh/YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh/YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh/YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh/YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh/YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFhYWFh/YWFhYWFhYWFhYWFhYWFhYWFhYWFhYWE
-}
-
 func Test_fragmentFileName_fragmentedFileNameToKey(t *testing.T) {
 	cases := []struct {
 		name      string

store/fscache/fscache_test.go

@@ -152,6 +152,11 @@ func TestOpen(t *testing.T) {
 					filepath.VolumeName(t.TempDir())+"/../invalid",
 				) + "?appname=myapp",
 			},
+			setup: func(tt *testing.T) {
+				if runtime.GOOS == "windows" {
+					tt.Skip("Skipping invalid path test on Windows")
+				}
+			},
 			assertion: func(tt *testing.T, got *fsCache, err error) {
 				testutil.RequireErrorIs(tt, err, ErrCreateCacheDir)
 				testutil.AssertNil(tt, got)
@@ -160,10 +165,7 @@ func TestOpen(t *testing.T) {
 		{
 			name: "Encryption Enabled with Key",
 			args: args{
-				dsn: "fscache://?appname=myapp&encrypt=aesgcm&encrypt_key=" + mustBase64Key(
-					t,
-					16,
-				),
+				dsn: "fscache://?appname=myapp&encrypt=aesgcm&encrypt_key=" + mustBase64Key(t, 16),
 			},
 			assertion: func(tt *testing.T, got *fsCache, err error) {
 				testutil.RequireNoError(tt, err)
@@ -200,6 +202,11 @@ func TestOpen(t *testing.T) {
 			args: args{
 				dsn: "fscache://?appname=myapp&connect_timeout=1ns&timeout=10s",
 			},
+			setup: func(tt *testing.T) {
+				if runtime.GOOS == "windows" {
+					tt.Skip("Skipping connect timeout test on Windows")
+				}
+			},
 			assertion: func(tt *testing.T, got *fsCache, err error) {
 				testutil.RequireErrorIs(tt, err, context.DeadlineExceeded)
 				testutil.AssertNil(tt, got)
@@ -212,7 +219,6 @@ func TestOpen(t *testing.T) {
 			if err != nil {
 				t.Fatalf("Failed to parse URL: %v", err)
 			}
-			t.Attr("URL", u.String())
 			if tt.setup != nil {
 				tt.setup(t)
 			}
@@ -242,7 +248,7 @@ func Test_parseTimeout(t *testing.T) {
 }
 
 func TestFSCache_SetGet_WithEncryption(t *testing.T) {
-	u, err := url.Parse("fscache://" + t.TempDir() +
+	u, err := url.Parse("fscache://" + filepath.ToSlash(t.TempDir()) +
 		"?appname=testapp&encrypt=aesgcm&encrypt_key=6S-Ks2YYOW0xMvTzKSv6QD30gZeOi1c6Ydr-As5csWk=")
 	testutil.RequireNoError(t, err)
 	cache, err := fromURL(u)

store/fscache/issue16_test.go

@@ -43,7 +43,15 @@ func Test_Issue16_LongURLFragmentation(t *testing.T) {
 		{"long URL (1KB)", 1024, true},
 		{"very long URL (4KB)", 4096, true},
 		{"extremely long URL (10KB)", 10240, true},
-		{"massive URL (100KB)", 102400, true},
+		{
+			// While Go's stdlib handles long paths via \\?\ prefix on Windows,
+			// extremely deep directory hierarchies (2844+ levels) may still hit
+			// practical filesystem or OS limits beyond just path length.
+			// See fixLongPath logic in os/path_windows.go (https://cs.opensource.google/go/go/+/refs/tags/go1.25.3:src/os/path_windows.go;l=100;drc=79b809afb325ae266497e21597f126a3e98a1ef7)
+			"massive URL (100KB)",
+			102400,
+			runtime.GOOS != "windows",
+		},
 	}
 
 	for _, tt := range tests {