Skip to content

Commit eb234b1

Browse files
dabankicopybara-github
authored andcommitted
Add deprecation warning to --build_python_zip. (#28527)
There was an [issue](#28348) surfaced where the native semantic `--nobuild_python_zip` had become a no-op due to the graveyarding/starlarkification of the option. The starlark flag version must use the `=` operator for assignment and can no longer work with the prefixed `no` option. This information was not surfaced in a great way causing confusion. Closes #28527. PiperOrigin-RevId: 866548743 Change-Id: Iff42d8f98767c9136757dfe318ac2ee054286509
1 parent ed98d31 commit eb234b1

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRulesModule.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,9 @@ public static class BuildGraveyardOptions extends OptionsBase {
6767
defaultValue = "auto",
6868
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
6969
effectTags = {OptionEffectTag.NO_OP},
70+
deprecationWarning =
71+
"The '--no' prefix is no longer supported for this flag. Please use"
72+
+ " --build_python_zip=false instead.",
7073
help = "Deprecated. No-op.")
7174
public TriState buildPythonZip;
7275

0 commit comments

Comments
 (0)