React Compiler lint rules

[arendjr]

The React Compiler has a corresponding ESLint plugin for reporting issues diagnosed by the compiler.

Unfortunately, as far as I'm aware, it is not documented what issues are reported by the plugin, so it is not even clear what Biome would need to implement exactly. The best target would be the Babel plugin, but it would be complex to port to Rust and it is itself still in beta and quite possibly a moving target.

Note that Biome does have lint rules to enforce the rules of hooks.

Suggestions and helpful pointers are appreciated in this thread!

[GRA0007]

To echo my feedback from #3 (reply in thread), I want to request that in the short term, we could have an option for the lint/correctness/useExhaustiveDependencies rule that disables just the [myFunc] changes on every re-render and should not be used as a hook dependency warning, as with the React compiler, function dependencies no longer need to be wrapped in a useCallback.

[arendjr]

Thanks! I’ve created #5293 for this.

[dmg-egg]

If it is helpful, the source code seems to be here (licensed under MIT): https://github.com/facebook/react/tree/main/compiler/packages/eslint-plugin-react-compiler

[Digital-Coder]

I'm not sure how BiomeJS was developed, but I’ll assume its rules were heavily inspired by ESLint. Based on the React documentation, it looks like eslint-plugin-react-compiler was merged into eslint-plugin-react-hooks@6.0.0-rc.1. Perhaps this information is helpful in creating a comparison of what needs to be implemented or ported to BiomeJS.

[arendjr]

I have also created a task for a new noReactPropAssign rule: #6077

This was always bad practice in React, and with the React Compiler it seems to have become a hard error.

[vladimir-ivanov]

@GRA0007 have you tried using eslint plugin for react hooks please?
"eslint-plugin-react-hooks": "6.0.0-rc.1",

I set it up on localhost, the error is still present in eslint as well.

if you could maybe setup a simple example with eslint where this is NOT showing? Will be very helpful.
many thanks

[robgraeber]

FWIW eslint-plugin-react-compiler is the only thing preventing me from ditching eslint.

[zbeyens]

Same here, here's the minimal eslint config I need to keep:

import tsParser from '@typescript-eslint/parser';
import { defineConfig } from 'eslint/config';
import reactHooks from 'eslint-plugin-react-hooks';

export default defineConfig([
  {
    ...reactHooks.configs.flat.recommended,
    files: ['src/**/*.ts*'],
    languageOptions: { parser: tsParser },
  },
  {
    ignores: [ 'node_modules/**' ]
  },
]);

[Siddhesh-Agarwal]

does biome migrate not take care of this?

[ataias]

The react compiler rules were moved to eslint-plugin-react-hooks, and there are rules that are not implemented yet in biome, so biome migrate can't be used to replace the above configuration on v6 and 7 of eslint-plugin-react-hooks.

[dandre-a5studio]

Are there any plans for this in the biome roadmap? I've had a great experience with biome so far but this is the first roadblock I've come across. I'd love to begin migrating my project to use the compiler but it would be a pain to rely only on the build time compiler errors.

Thank you biome team ❤️

[jasurabdullin]

Bumping for visibility. Any updates on this?