Check ticket parameters

Author: abitmore

libraries/chain/hardfork.d/20250518.hf

@@ -0,0 +1,5 @@
+// Ticket issues
+#ifndef SOFTFORK_20250518_TIME
+#define SOFTFORK_20250518_TIME (fc::time_point_sec( 1747555200 )) // Sunday, May 18, 2025 8:00:00 UTC
+#define SOFTFORK_20250518_PASSED(head_block_time) (head_block_time >= SOFTFORK_20250518_TIME)
+#endif

libraries/chain/proposal_evaluator.cpp

@@ -262,9 +262,16 @@ struct proposal_operation_hardfork_visitor
    }
    void operator()(const graphene::chain::ticket_create_operation&) const {
       FC_ASSERT( HARDFORK_CORE_2103_PASSED(block_time), "Not allowed until hardfork 2103" );
+      if( SOFTFORK_20250518_PASSED(block_time) ) {
+         FC_ASSERT( false, "Temporarily disabled" );
+      }
    }
-   void operator()(const graphene::chain::ticket_update_operation&) const {
+   void operator()(const graphene::chain::ticket_update_operation& op) const {
       FC_ASSERT( HARDFORK_CORE_2103_PASSED(block_time), "Not allowed until hardfork 2103" );
+      if( SOFTFORK_20250518_PASSED(block_time)
+          && op.target_type == static_cast<uint64_t>(ticket_type::lock_forever) ) {
+         FC_ASSERT( false, "Temporarily disabled" );
+      }
    }
    void operator()(const graphene::chain::liquidity_pool_create_operation&) const {
       FC_ASSERT( HARDFORK_LIQUIDITY_POOL_PASSED(block_time), "Not allowed until the LP hardfork" );

libraries/chain/ticket_evaluator.cpp

@@ -33,13 +33,53 @@
 
 namespace graphene { namespace chain {
 
+namespace detail {
+
+   void check_ticket_params_sf250518(const database& d, const ticket_create_operation& op)
+   {
+      const auto& idx = d.get_index_type<ticket_index>().indices().get<by_account>();
+      auto itr = idx.lower_bound( op.account );
+      auto itr_end = idx.upper_bound( op.account );
+      share_type total_forever_amount;
+      share_type total_other_amount;
+      for( ; itr != itr_end; ++itr )
+      {
+         const auto& t = *itr;
+         if( t.target_type == ticket_type::lock_forever )
+            total_forever_amount += t.amount.amount;
+         else
+            total_other_amount += t.amount.amount;
+      }
+
+      if( op.target_type == static_cast<uint64_t>(ticket_type::lock_forever) )
+      {
+         const share_type max_forever_amount( int64_t(1000) * GRAPHENE_BLOCKCHAIN_PRECISION );
+         if ( total_forever_amount + op.amount.amount > max_forever_amount )
+            FC_ASSERT( false, "Temporarily unacceptable" );
+      }
+      else
+      {
+         const asset_id_type a(6623);
+         const auto b = d.get_balance( op.account, a );
+         const share_type max_other_amount = b.amount;
+         if ( total_other_amount + op.amount.amount > max_other_amount )
+            FC_ASSERT( false, "Temporarily unacceptable" );
+      }
+   }
+
+};
+
 void_result ticket_create_evaluator::do_evaluate(const ticket_create_operation& op)
 { try {
    const database& d = db();
    const auto block_time = d.head_block_time();
 
    FC_ASSERT( HARDFORK_CORE_2103_PASSED(block_time), "Not allowed until hardfork 2103" );
 
+   if( SOFTFORK_20250518_PASSED(block_time) ) {
+      detail::check_ticket_params_sf250518( d, op );
+   }
+
    return void_result();
 } FC_CAPTURE_AND_RETHROW( (op) ) }
 
@@ -70,6 +110,12 @@ void_result ticket_update_evaluator::do_evaluate(const ticket_update_operation&
 { try {
    database& d = db();
 
+   const auto block_time = d.head_block_time();
+   if( SOFTFORK_20250518_PASSED(block_time)
+       && op.target_type == static_cast<uint64_t>(ticket_type::lock_forever) ) {
+      FC_ASSERT( false, "Temporarily disabled" );
+   }
+
    _ticket = &op.ticket(d);
 
    FC_ASSERT( _ticket->account == op.account, "Ticket is not owned by the account" );