Merge pull request #95 from victormacko/master

mnapoli · web-flow · commit 643e6915e9ef · 2025-02-13T14:44:02.000+01:00
Fix up issue for PHPStan (check if stamp is a SnsFifoStamp)
diff --git a/src/Service/Sns/SnsTransport.php b/src/Service/Sns/SnsTransport.php
@@ -41,7 +41,7 @@ public function send(Envelope $envelope): Envelope
         if (str_contains($this->topic, ".fifo")) {
             $stamps = $envelope->all();
             $dedupeStamp = $stamps[SnsFifoStamp::class][0] ?? false;
-            if (!$dedupeStamp) {
+            if (!$dedupeStamp || $dedupeStamp instanceof SnsFifoStamp == false) {
                 throw new Exception("SnsFifoStamp required for fifo topic");
             }
             $messageGroupId = $dedupeStamp->getMessageGroupId() ?? false;

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function send(Envelope $envelope): Envelope`
`41`	`41`	`if (str_contains($this->topic, ".fifo")) {`
`42`	`42`	`$stamps = $envelope->all();`
`43`	`43`	`$dedupeStamp = $stamps[SnsFifoStamp::class][0] ?? false;`
`44`		`- if (!$dedupeStamp) {`
	`44`	`+ if (!$dedupeStamp \|\| $dedupeStamp instanceof SnsFifoStamp == false) {`
`45`	`45`	`throw new Exception("SnsFifoStamp required for fifo topic");`
`46`	`46`	`}`
`47`	`47`	`$messageGroupId = $dedupeStamp->getMessageGroupId() ?? false;`