Skip to content

Commit 90e34b8

Browse files
committed
revert incorrect error handling for missing cert secret
don't return an error and start the loop over, issue a cert and save it to the secret
1 parent b1d6826 commit 90e34b8

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

pkg/controller/certificaterequest/certificaterequest_controller.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -221,17 +221,14 @@ func (r *ReconcileCertificateRequest) Reconcile(request reconcile.Request) (reco
221221

222222
found := &corev1.Secret{}
223223

224-
err = r.client.Get(context.TODO(), types.NamespacedName{Name: cr.Spec.CertificateSecret.Name, Namespace: cr.Namespace}, found)
225-
if err != nil {
226-
return reconcile.Result{}, err
227-
}
228-
229224
leClient, err := leclient.NewClient(r.client)
230225
if err != nil {
231226
reqLogger.Error(err, "failed to get letsencrypt client")
232227
return reconcile.Result{}, err
233228
}
234229

230+
err = r.client.Get(context.TODO(), types.NamespacedName{Name: cr.Spec.CertificateSecret.Name, Namespace: cr.Namespace}, found)
231+
235232
// Issue new certificates if the secret does not already exist
236233
if err != nil {
237234
if errors.IsNotFound(err) {

0 commit comments

Comments
 (0)