-
Notifications
You must be signed in to change notification settings - Fork 94
Open
Labels
improvementExisting functionality that needs improvementsExisting functionality that needs improvements
Description
Problem
Submit view ( /submit ) has missing/incomplete/non uniform error handling for cases when no file or url is added.
File:
- Currently no error handling present if no file is selected and
Configure analysisbutton is pressed. - Configure analysis button is blue and active but does nothing when file is not seleted.
URL:
- When no URL is entered into input box, and
Configure analysisbutton is pressed, browser displays error page with status code 400. That is not consistent with the rest of error handling on submit view like['Cannot validate this URL: htteps://some.malformed.url']popup for invalid URL.
General errors:
- In case of error, user is redirected to
submit/index.html.jinja2template.- Errors must be displayed on the tab where the error occurs.
Scope
Web UI - submit/
Solution
File submit:
-
Configure analysisbutton is disabled when no file is selected. -
Configure analysisbutton is enabled when file is selected.
URL submit:
- URL tab
Configure analysisbutton is enabled - URL input type is
urlandpattern=matches correct http:// or https:// url pattern for atleast top level domain. - Complete URL validation remains inside Django for now
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
improvementExisting functionality that needs improvementsExisting functionality that needs improvements