Skip to content

Commit 28733ec

Browse files
committed
Fix failing due to test errors and possible deployment bugs
1 parent be044d4 commit 28733ec

File tree

2 files changed

+10
-38
lines changed

2 files changed

+10
-38
lines changed

.github/workflows/develop.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,6 @@ jobs:
328328
id: create-markdown-cs
329329
uses: aws-actions/aws-cloudformation-github-deploy@v2.0.0-beta
330330
with:
331-
mode: "create-only"
332331
name: test-markdown-${{ github.run_number }}
333332
template: markdown-test-template.yaml
334333
parameter-overrides: "Environment=test"

event-streaming-test.yaml

Lines changed: 10 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -11,35 +11,6 @@ Parameters:
1111
Description: 'Delay in seconds for Lambda function'
1212

1313
Resources:
14-
EventTestVPC:
15-
Type: AWS::EC2::VPC
16-
Properties:
17-
CidrBlock: 10.0.0.0/16
18-
EnableDnsHostnames: true
19-
EnableDnsSupport: true
20-
Tags:
21-
- Key: Name
22-
Value: !Sub "${Environment}-event-test-vpc"
23-
24-
EventTestSubnet:
25-
Type: AWS::EC2::Subnet
26-
Properties:
27-
VpcId: !Ref EventTestVPC
28-
CidrBlock: 10.0.1.0/24
29-
AvailabilityZone: !Select [0, !GetAZs '']
30-
Tags:
31-
- Key: Name
32-
Value: !Sub "${Environment}-event-test-subnet"
33-
34-
EventTestSecurityGroup:
35-
Type: AWS::EC2::SecurityGroup
36-
Properties:
37-
GroupDescription: Security group for event streaming test
38-
VpcId: !Ref EventTestVPC
39-
SecurityGroupEgress:
40-
- IpProtocol: -1
41-
CidrIp: 0.0.0.0/0
42-
4314
EventTestRole:
4415
Type: AWS::IAM::Role
4516
Properties:
@@ -51,7 +22,7 @@ Resources:
5122
Service: lambda.amazonaws.com
5223
Action: sts:AssumeRole
5324
ManagedPolicyArns:
54-
- arn:aws:iam::aws:policy/service-role/AWSLambdaVPCAccessExecutionRole
25+
- arn:aws:iam::aws:policy/service-role/AWSLambdaBasicExecutionRole
5526

5627
EventTestFunction:
5728
Type: AWS::Lambda::Function
@@ -60,20 +31,22 @@ Resources:
6031
Runtime: python3.9
6132
Handler: index.handler
6233
Role: !GetAtt EventTestRole.Arn
63-
VpcConfig:
64-
SecurityGroupIds:
65-
- !Ref EventTestSecurityGroup
66-
SubnetIds:
67-
- !Ref EventTestSubnet
6834
Code:
6935
ZipFile: !Sub |
7036
import time
7137
def handler(event, context):
7238
time.sleep(${DelaySeconds})
7339
return {'statusCode': 200, 'body': 'Event streaming test complete'}
7440
41+
EventTestParameter:
42+
Type: AWS::SSM::Parameter
43+
Properties:
44+
Name: !Sub "/${Environment}/event-test/config"
45+
Type: String
46+
Value: !Sub "event-streaming-test-${DelaySeconds}s"
47+
7548
Outputs:
76-
VPCId:
77-
Value: !Ref EventTestVPC
7849
FunctionArn:
7950
Value: !GetAtt EventTestFunction.Arn
51+
ParameterName:
52+
Value: !Ref EventTestParameter

0 commit comments

Comments
 (0)