Use successful retrieval

Author: chrisqm-dev

.github/workflows/develop.yaml

@@ -463,36 +463,33 @@ jobs:
           role-to-assume: ${{ secrets.AWS_ROLE_TO_ASSUME }}
           aws-region: us-east-1
 
-      - name: Test stack creation that fails to retrieve stack ID
-        id: create-failing-stack
+      - name: Test stack creation with ID retrieval
+        id: create-stack
         uses: aws-actions/aws-cloudformation-github-deploy@v2.0.0-beta
         with:
-          name: test-failing-stack-id-${{ github.run_number }}
-          template: failing-stack.yaml
-          parameter-overrides: "Environment=test"
-        continue-on-error: true
+          name: test-stack-id-${{ github.run_number }}
+          template: stack.yaml
+          parameter-overrides: "Environment=beta"
 
-      - name: Verify stack ID retrieval on failure
+      - name: Verify stack ID retrieval
         run: |
-          STACK_ID="${{ steps.create-failing-stack.outputs.stack-id }}"
+          STACK_ID="${{ steps.create-stack.outputs.stack-id }}"
           echo "Stack ID: $STACK_ID"
-          echo "Deployment outcome: ${{ steps.create-failing-stack.outcome }}"
+          echo "Deployment outcome: ${{ steps.create-stack.outcome }}"
           
-          # For failed deployments, we should get a stack ID (ARN) for debugging
-          if [[ "${{ steps.create-failing-stack.outcome }}" == "failure" ]]; then
-            if [[ $STACK_ID == arn:aws:cloudformation:* ]]; then
-              echo "✅ Stack ID retrieved successfully for failed deployment"
-              # Verify we can access the failed stack for debugging
-              aws cloudformation describe-stacks --stack-name "$STACK_ID"
-              echo "✅ Failed stack is accessible for debugging"
-            else
-              echo "❌ Expected stack ARN for failed deployment, got: $STACK_ID"
-              exit 1
-            fi
+          # Should get either ARN or stack name for successful deployment
+          if [[ $STACK_ID == arn:aws:cloudformation:* ]]; then
+            echo "✅ Got stack ARN: $STACK_ID"
+          elif [[ "$STACK_ID" == "test-stack-id-${{ github.run_number }}" ]]; then
+            echo "✅ Got stack name: $STACK_ID"
           else
-            echo "❌ Expected deployment to fail for this test"
+            echo "❌ Unexpected stack ID: $STACK_ID (expected ARN or stack name)"
             exit 1
           fi
+          
+          # Verify we can access the stack
+          aws cloudformation describe-stacks --stack-name "$STACK_ID"
+          echo "✅ Stack is accessible"
 
   test-execute-only-with-events:
     runs-on: ubuntu-latest