fix(sunpath): Fix bug with reversed daylight savings periods

Resolves ladybug-tools/ladybug-grasshopper#401 (comment)

Author: chriswmackey

.github/workflows/ci.yaml

@@ -55,7 +55,7 @@ jobs:
         run: |
           nextRelease="`npx semantic-release@^23.1.1 --dryRun | grep -oP 'Published release \K.*? ' || true`"
           npx semantic-release@^23.1.1
-          echo "::set-output name=tag::$nextRelease"
+          echo "tag=$nextRelease" >> $GITHUB_OUTPUT
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           PYPI_PASSWORD: ${{ secrets.PYPI_PASSWORD }}

Dockerfile

@@ -22,7 +22,6 @@ RUN mkdir ladybug_tools && touch ladybug_tools/config.json
 COPY ladybug ${LIBRARYDIR}/ladybug
 COPY .git ${LIBRARYDIR}/.git
 COPY setup.py ${LIBRARYDIR}
-COPY setup.cfg ${LIBRARYDIR}
 COPY requirements.txt ${LIBRARYDIR}
 COPY README.md ${LIBRARYDIR}
 COPY LICENSE ${LIBRARYDIR}

deploy.sh

@@ -12,7 +12,7 @@ CONTAINER_NAME="ladybugtools/ladybug"
 
 echo "PyPi Deployment..."
 echo "Building distribution"
-python setup.py sdist bdist_wheel
+python -m build
 echo "Pushing new version to PyPi"
 twine upload dist/* -u $PYPI_USERNAME -p $PYPI_PASSWORD 
 

dev-requirements.txt

@@ -4,15 +4,16 @@ sphinx-bootstrap-theme==0.8.1
 sphinxcontrib-fulltoc==1.2.0
 sphinxcontrib-websupport==2.0.0;python_version>='3.6'
 sphinx-click==6.0.0;python_version>='3.6'
-twine==5.1.1;python_version>='3.6'
-wheel==0.44.0;python_version>='3.6'
-setuptools==75.1.0;python_version>='3.6'
-importlib-metadata==8.5.0;python_version>='3.6'
+twine==6.1.0;python_version>='3.6'
+wheel==0.45.1;python_version>='3.6'
+setuptools==80.9.0;python_version>='3.6'
+build==1.3.0;python_version>='3.6'
 pytest==4.6.9;python_version<'3.0'
 Sphinx==1.8.5;python_version<'3.0'
 sphinxcontrib-websupport==1.1.2;python_version<'3.0'
 sphinx-click==4.4.0;python_version<'3.0'
 twine==1.13.0;python_version<'3.0'
 wheel==0.38.1;python_version<'3.0'
 setuptools==44.1.0;python_version<'3.0'
+build==0.1.0;python_version<'3.0'
 importlib-metadata==2.0.0;python_version<'3.0'

ladybug/sunpath.py

@@ -179,8 +179,8 @@ def is_daylight_saving_hour(self, datetime):
         if not self.daylight_saving_period:
             return False
         if self.daylight_saving_period.is_reversed:
-            return self.daylight_saving_period.end_time.moy <= datetime.moy or \
-                self.daylight_saving_period.st_time.moy >= datetime.moy
+            return datetime.moy <= self.daylight_saving_period.end_time.moy or \
+                datetime.moy >= self.daylight_saving_period.st_time.moy
         else:
             return self.daylight_saving_period.st_time.moy <= datetime.moy < \
                 self.daylight_saving_period.end_time.moy

setup.cfg

@@ -24,10 +24,14 @@
     },
     classifiers=[
         "Programming Language :: Python :: 2.7",
-        "Programming Language :: Python :: 3.6",
         "Programming Language :: Python :: 3.7",
+        "Programming Language :: Python :: 3.8",
+        "Programming Language :: Python :: 3.9",
+        "Programming Language :: Python :: 3.10",
+        "Programming Language :: Python :: 3.11",
+        "Programming Language :: Python :: 3.12",
         "Programming Language :: Python :: Implementation :: CPython",
-        "License :: OSI Approved :: GNU Affero General Public License v3",
+        "Programming Language :: Python :: Implementation :: IronPython",
         "Operating System :: OS Independent"
     ],
     license="AGPL-3.0"