feat: Upstream Arc-related changes (#1375)

Closes: #1364

Author: romac

.github/workflows/coverage.yml

@@ -86,63 +86,64 @@ jobs:
           flags: integration
           fail_ci_if_error: false
 
-  mbt:
-    name: MBT
-    needs: changes
-    if: ${{ needs.changes.outputs.code == 'true' || needs.changes.outputs.specs == 'true' || needs.changes.outputs.codecov == 'true' || github.ref == 'refs/heads/main' }}
-    runs-on: github-hosted-small
-    defaults:
-      run:
-        working-directory: code
-    env:
-      CARGO_TERM_COLOR: always
-    steps:
-      - name: Checkout
-        uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
-      - name: Install Protoc
-        uses: step-security/setup-protoc@f6eb248a6510dbb851209febc1bd7981604a52e3 # v3
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-      - name: Setup Node
-        uses: actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610 # v3
-        with:
-          node-version: "18"
-      - name: Install Quint
-        run: npm install -g @informalsystems/quint
-      - name: Setup Rust toolchain
-        uses: actions-rust-lang/setup-rust-toolchain@1780873c7b576612439a134613cc4cc74ce5538c # v1
-        with:
-          toolchain: nightly-2025-01-07 # pin to working nightly
-          components: llvm-tools-preview
-      - name: Install cargo-nextest
-        uses: taiki-e/install-action@ea550356e2321dfdcd1d315eb6bf64d259aa5da1 # cargo-nextest
-      - name: Install cargo-llvm-cov
-        uses: taiki-e/install-action@4f58db3287097306b1c9381106c8445b616d3c08 # cargo-llvm-cov
-      - name: Generate code coverage
-        run: |
-          cargo llvm-cov nextest \
-           -p informalsystems-malachitebft-test-mbt \
-           -p informalsystems-malachitebft-starknet-test-mbt \
-           --all-features --codecov --output-path coverage-mbt.info
-      - name: Generate text report
-        run: cargo llvm-cov report
-      - name: Upload coverage artifact
-        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
-        with:
-          name: mbt-coverage
-          path: code/coverage-mbt.info
-          retention-days: 1
-      - name: Upload test results to Codecov
-        if: ${{ !cancelled() }}
-        uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1
-        with:
-          token: ${{ secrets.CODECOV_TOKEN }}
-          flags: mbt
-          fail_ci_if_error: false
+  # mbt:
+  #   name: MBT
+  #   needs: changes
+  #   if: ${{ needs.changes.outputs.code == 'true' || needs.changes.outputs.specs == 'true' || needs.changes.outputs.codecov == 'true' || github.ref == 'refs/heads/main' }}
+  #   runs-on: github-hosted-small
+  #   defaults:
+  #     run:
+  #       working-directory: code
+  #   env:
+  #     CARGO_TERM_COLOR: always
+  #   steps:
+  #     - name: Checkout
+  #       uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
+  #     - name: Install Protoc
+  #       uses: step-security/setup-protoc@f6eb248a6510dbb851209febc1bd7981604a52e3 # v3
+  #       with:
+  #         repo-token: ${{ secrets.GITHUB_TOKEN }}
+  #     - name: Setup Node
+  #       uses: actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610 # v3
+  #       with:
+  #         node-version: "18"
+  #     - name: Install Quint
+  #       run: npm install -g @informalsystems/quint
+  #     - name: Setup Rust toolchain
+  #       uses: actions-rust-lang/setup-rust-toolchain@1780873c7b576612439a134613cc4cc74ce5538c # v1
+  #       with:
+  #         toolchain: nightly-2025-01-07 # pin to working nightly
+  #         components: llvm-tools-preview
+  #     - name: Install cargo-nextest
+  #       uses: taiki-e/install-action@ea550356e2321dfdcd1d315eb6bf64d259aa5da1 # cargo-nextest
+  #     - name: Install cargo-llvm-cov
+  #       uses: taiki-e/install-action@4f58db3287097306b1c9381106c8445b616d3c08 # cargo-llvm-cov
+  #     - name: Generate code coverage
+  #       run: |
+  #         cargo llvm-cov nextest \
+  #          -p informalsystems-malachitebft-test-mbt \
+  #          -p informalsystems-malachitebft-starknet-test-mbt \
+  #          --all-features --codecov --output-path coverage-mbt.info
+  #     - name: Generate text report
+  #       run: cargo llvm-cov report
+  #     - name: Upload coverage artifact
+  #       uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
+  #       with:
+  #         name: mbt-coverage
+  #         path: code/coverage-mbt.info
+  #         retention-days: 1
+  #     - name: Upload test results to Codecov
+  #       if: ${{ !cancelled() }}
+  #       uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1
+  #       with:
+  #         token: ${{ secrets.CODECOV_TOKEN }}
+  #         flags: mbt
+  #         fail_ci_if_error: false
 
   upload-coverage:
     name: Upload coverage to Codecov
-    needs: [changes, integration, mbt]
+    # needs: [changes, integration, mbt]
+    # needs: [changes, integration]
     runs-on: github-hosted-small
     if: ${{ !cancelled() && (needs.changes.outputs.code == 'true' || needs.changes.outputs.specs == 'true' || needs.changes.outputs.codecov == 'true' || github.ref == 'refs/heads/main') }}
     steps:
@@ -155,11 +156,11 @@ jobs:
         with:
           name: integration-coverage
           path: code/coverage
-      - name: Download MBT coverage
-        uses: actions/download-artifact@v4
-        with:
-          name: mbt-coverage
-          path: code/coverage
+      # - name: Download MBT coverage
+      #   uses: actions/download-artifact@v4
+      #   with:
+      #     name: mbt-coverage
+      #     path: code/coverage
       - name: List coverage files
         run: ls -la code/coverage
       - name: Upload integration coverage to Codecov
@@ -168,9 +169,9 @@ jobs:
           bash <(curl -s https://codecov.io/bash) -f coverage/coverage-integration.info -F integration
         env:
           CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
-      - name: Upload MBT coverage to Codecov
-        working-directory: code
-        run: |
-          bash <(curl -s https://codecov.io/bash) -f coverage/coverage-mbt.info -F mbt
-        env:
-          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+      # - name: Upload MBT coverage to Codecov
+      #   working-directory: code
+      #   run: |
+      #     bash <(curl -s https://codecov.io/bash) -f coverage/coverage-mbt.info -F mbt
+      #   env:
+      #     CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/mbt.yml

@@ -45,7 +45,7 @@ jobs:
         with:
           node-version: "18"
       - name: Install Quint
-        run: npm install -g @informalsystems/quint
+        run: npm install -g @informalsystems/quint@0.27.0
       - name: Setup Rust toolchain
         uses: actions-rust-lang/setup-rust-toolchain@v1
       - name: Install cargo-nextest

.github/workflows/rust.yml

@@ -43,12 +43,12 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Setup Node
-        uses: actions/setup-node@v3
-        with:
-          node-version: "18"
-      - name: Install Quint
-        run: npm install -g @informalsystems/quint
+      # - name: Setup Node
+      #   uses: actions/setup-node@v3
+      #   with:
+      #     node-version: "18"
+      # - name: Install Quint
+      #   run: npm install -g @informalsystems/quint
       - name: Setup Rust toolchain
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
@@ -63,6 +63,7 @@ jobs:
             --no-fail-fast \
             --failure-output final \
             --exclude informalsystems-malachitebft-test \
+            --exclude informalsystems-malachitebft-test-mbt \
             --exclude informalsystems-malachitebft-starknet-test \
             --exclude informalsystems-malachitebft-starknet-test-mbt \
             --exclude informalsystems-malachitebft-discovery-test
@@ -78,12 +79,12 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-      - name: Setup Node
-        uses: actions/setup-node@v3
-        with:
-          node-version: "18"
-      - name: Install Quint
-        run: npm install -g @informalsystems/quint
+      # - name: Setup Node
+      #   uses: actions/setup-node@v3
+      #   with:
+      #     node-version: "18"
+      # - name: Install Quint
+      #   run: npm install -g @informalsystems/quint
       - name: Setup Rust toolchain
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:

BREAKING_CHANGES.md

@@ -4,23 +4,9 @@
 
 ### `malachitebft-core-types`
 
-- Move `SigningProvider` and `SigningProviderExt` traits into new `malachitebft-signing` crate ([#1191](https://github.com/informalsystems/malachite/pull/1191))
 - Added new associated type `Timeouts` to the `Context` trait (use `LinearTimeouts` for default implementation) ([#1227](https://github.com/circlefin/malachite/pull/1227))
 - Remove `initial_validator_set` and `initial_height` fields from `Params` struct ([#1190](https://github.com/circlefin/malachite/pull/1190))
 
-### `malachitebft-signing`
-
-- New crate exposing the `SigningProvider` trait ([#1191](https://github.com/informalsystems/malachite/pull/1191))
-- Make methods of `SigningProvider` and `SigningProviderExt` traits fallible ([#1191](https://github.com/informalsystems/malachite/pull/1191))
-- Changed methods of `SigningProvider` and `SigningProviderExt` traits to `async` ([#1151](https://github.com/informalsystems/malachite/issues/1151))
-
-### `malachitebft-core-consensus`
-
-- Remove `GetValidatorSet` effect ([#1189](https://github.com/circlefin/malachite/pull/1189))
-- Removed `Effect::ResetTimeouts` variant ([#1227](https://github.com/circlefin/malachite/pull/1227))
-- Changed `Input::StartHeight` from `StartHeight(Height, ValidatorSet, bool)` to `StartHeight(Height, Option<ValidatorSet>, bool)` ([#1227](https://github.com/circlefin/malachite/pull/1227))
-- Changed `State::reset_and_start_height()` signature from `(height, validator_set)` to `(height, validator_set: Option<ValidatorSet>)` ([#1227](https://github.com/circlefin/malachite/pull/1227))
-
 ### `malachitebft-core-driver`
 
 - Changed `Driver::new()` signature - removed `timeouts` parameter ([#1227](https://github.com/circlefin/malachite/pull/1227))
@@ -30,9 +16,14 @@
 - Removed `timeouts` field from `Driver` struct - Driver no longer stores or manages timeouts ([#1227](https://github.com/circlefin/malachite/pull/1227))
 - Changed `Driver::move_to_height` signature from `move_to_height(Height, Validator_set, Timeouts)` to `move_to_height(Height, Option<ValidatorSet>)` ([#1227](https://github.com/circlefin/malachite/pull/1227))
 
+### `malachitebft-core-consensus`
+
+- Removed `Effect::ResetTimeouts` variant ([#1227](https://github.com/circlefin/malachite/pull/1227))
+- Changed `Input::StartHeight` from `StartHeight(Height, ValidatorSet, bool)` to `StartHeight(Height, Option<ValidatorSet>, bool)` ([#1227](https://github.com/circlefin/malachite/pull/1227))
+- Changed `State::reset_and_start_height()` signature from `(height, validator_set)` to `(height, validator_set: Option<ValidatorSet>)` ([#1227](https://github.com/circlefin/malachite/pull/1227))
+
 ### `malachitebft-engine`
 
-- Remove `HostMsg::GetValidatorSet` ([#1189](https://github.com/circlefin/malachite/pull/1189))
 - Changed `Next::Start` variant from `Start(Height, ValidatorSet)` to `Start(Height, HeightParams)` ([#1227](https://github.com/circlefin/malachite/pull/1227))
 - Changed `Next::Restart` variant from `Restart(Height, ValidatorSet)` to `Restart(Height, HeightParams)` ([#1227](https://github.com/circlefin/malachite/pull/1227))
 - Changed `HostMsg::ConsensusReady` reply type from `(Ctx::Height, Ctx::ValidatorSet)` to `(Ctx::Height, HeightParams<Ctx>)` ([#1227](https://github.com/circlefin/malachite/pull/1227))
@@ -42,18 +33,47 @@
 
 ### `malachitebft-config`
 
-- Added field `channel_names: ChannelNames` to `NetworkConfig` struct ([#849](https://github.com/informalsystems/malachite/pull/849))
 - Removed `TimeoutConfig` struct ([#1227](https://github.com/circlefin/malachite/pull/1227))
 - Removed `timeouts` field from `ConsensusConfig` struct (timeouts are now managed via `Context::Timeouts` associated type) ([#1227](https://github.com/circlefin/malachite/pull/1227))
 
 ### `malachitebft-app-channel`
 
-- Remove `AppMsg::GetValidatorSet` ([#1189](https://github.com/circlefin/malachite/pull/1189))
-- Added field `requests: tokio::sync::mpsc::Sender<ConsensusRequest<Ctx>>` to `Channels` struct ([#1176](https://github.com/circlefin/malachite/pull/1176))
 - Changed `AppMsg::ConsensusReady` reply type from `(Ctx::Height, Ctx::ValidatorSet)` to `(Ctx::Height, HeightParams<Ctx>)` ([#1227](https://github.com/circlefin/malachite/pull/1227))
 - Changed `ConsensusMsg::StartHeight` from `StartHeight(Height, ValidatorSet)` to `StartHeight(Height, HeightParams)` ([#1227](https://github.com/circlefin/malachite/pull/1227))
 - Changed `ConsensusMsg::RestartHeight` from `RestartHeight(Height, ValidatorSet)` to `RestartHeight(Height, HeightParams)` ([#1227](https://github.com/circlefin/malachite/pull/1227))
 
+### `malachitebft-app`
+
+- Removed `Node` trait
+
+## 0.6.0
+
+### `malachitebft-core-types`
+
+- Move `SigningProvider` and `SigningProviderExt` traits into new `malachitebft-signing` crate ([#1191](https://github.com/informalsystems/malachite/pull/1191))
+
+### `malachitebft-signing`
+
+- New crate exposing the `SigningProvider` trait ([#1191](https://github.com/informalsystems/malachite/pull/1191))
+- Make methods of `SigningProvider` and `SigningProviderExt` traits fallible ([#1191](https://github.com/informalsystems/malachite/pull/1191))
+- Changed methods of `SigningProvider` and `SigningProviderExt` traits to `async` ([#1151](https://github.com/informalsystems/malachite/issues/1151))
+
+### `malachitebft-core-consensus`
+
+- Remove `GetValidatorSet` effect ([#1189](https://github.com/circlefin/malachite/pull/1189))
+
+### `malachitebft-engine`
+
+- Remove `HostMsg::GetValidatorSet` ([#1189](https://github.com/circlefin/malachite/pull/1189))
+
+### `malachitebft-config`
+
+- Added field `channel_names: ChannelNames` to `NetworkConfig` struct ([#849](https://github.com/informalsystems/malachite/pull/849))
+
+### `malachitebft-app-channel`
+
+- Remove `AppMsg::GetValidatorSet` ([#1189](https://github.com/circlefin/malachite/pull/1189))
+- Added field `requests: tokio::sync::mpsc::Sender<ConsensusRequest<Ctx>>` to `Channels` struct ([#1176](https://github.com/circlefin/malachite/pull/1176))
 
 ## 0.5.0
 

RELEASE_NOTES.md

@@ -2,6 +2,53 @@
 
 ## Unreleased
 
+### `app-channel`
+- Make consensus request channel capacity configurable
+- Refactor infrastructure for spawning a channel-based application
+
+### `consensus`
+- Allow application to change its mind about validity (invalid -> valid)
+- Allow dynamic adjustment of timeout parameters ([#1227](https://github.com/circlefin/malachite/pull/1227))
+- Allow providing both the validator set and the timeouts for a height in `StartHeight`, `RestartHeight` and `ConsensusReady` reply ([#1227](https://github.com/circlefin/malachite/pull/1227))
+- Remove `initial_validator_set` and `initial_height` fields from `Params` struct ([#1190](https://github.com/circlefin/malachite/pull/1190))
+
+### `discovery`
+- Can connect request calls the wrong controller action
+- Clear connect_request done_on to allow re-upgrading the peer on reconnection
+- Don't add peers with empty address list to dial queue
+- Don't cancel outgoing dials when receiving inbound connection from same peer
+- Ensure discovery configuration is passed down to the networking module
+- Fix peer and connection metrics when discovery is disabled
+- Prevent address poisoning when discovery is enabled
+- Prevent address spoofing in persistent peer detection
+
+### `driver`
+- Check for polka certificate to multiplex `PolkaValue` output on step change
+- Ensure `PrecommitAny` does not shadow `PolkaNil` and `PolkaAny` pending inputs
+- Ensure polka certificate is matched against a proposal for the same value
+- Produce `InvalidProposalAndPolkaPrevious` when receiving a polka certificate matching the POL round of a proposal with an invalid value
+
+### `network`
+- Add `persistent_peers_only` config option to allow connections ONLY from/to persistent peers
+- Add a mechanism to dump the network state
+- Add application-specific peer scoring for Gossipsub to prioritize nodes based on their types, in mesh formation and maintenance
+- Add network metrics for peer identification and tracking
+- Add transport level connection limits
+- Limit the number of peers that can connect from same IP address
+
+### `signing`
+- Implement `SigningProvider` for `Arc<T>` where `T: SigningProvider`
+- Remove signing of proposal parts
+
+### `sync`
+- Initial random (fixed) period adjustment in sync status ticker
+- Support batch retrieval of decided values
+- Validate value request ranges before processing
+
+## 0.6.0
+
+*November 19th, 2025*
+
 - Remove `Effect::GetValidatorSet`, `AppMsg::GetValidatorSet` and `HostMsg::GetValidatorSet` ([#1189](https://github.com/circlefin/malachite/pull/1189))
 - Introduce `malachitebft-signing` crate for exposing the `SigningProvider` and `SigningProviderExt` traits ([#1191](https://github.com/informalsystems/malachite/pull/1191))
 - Make `SigningProvider` trait methods fallible ([#1191](https://github.com/informalsystems/malachite/pull/1191))
@@ -11,9 +58,6 @@
 - Add facility for app to request a consensus state dump at any time ([#1176](https://github.com/informalsystems/malachite/pull/1176))
 - Make libp2p protocol names configurable ([#1161](https://github.com/informalsystems/malachite/issues/1161))
 - Fix mismatched height of WAL entries emitted when processing `StartHeight` input ([#1232](https://github.com/circlefin/malachite/issues/1232))
-- Allow dynamic adjustment of timeout parameters ([#1227](https://github.com/circlefin/malachite/pull/1227))
-- Allow providing both the validator set and the timeouts for a height in `StartHeight`, `RestartHeight` and `ConsensusReady` reply ([#1227](https://github.com/circlefin/malachite/pull/1227))
-- Remove `initial_validator_set` and `initial_height` fields from `Params` struct ([#1190](https://github.com/circlefin/malachite/pull/1190))
 
 ## 0.5.0