Skip to content

Building against BoringSSL fails, easy fix #744

@kmansoft

Description

@kmansoft

Hello,

I'm trying to build libSRTP against BoringSSL using CMake.

Running into an issue in that CMakeLists.txt requires a specific OpenSSL version - 1.1.0 or newer - and BoringSSL doesn't define a version number, so the FindPackage here fails:

https://github.com/cisco/libsrtp/blob/main/CMakeLists.txt#L103

https://github.com/Kitware/CMake/blob/master/Modules/FindOpenSSL.cmake#L576

https://boringssl.googlesource.com/boringssl/+/HEAD/include/openssl/opensslv.h

Since OpenSSL 1.1.0 is from 25 Aug 2016, and was EOL'd in September 2019, I think it's safe to assume that any OpenSSL version would be compliant.

Would it be possible to remove the version requirement from CMakeLists.txt like this:

Current:

find_package(OpenSSL 1.1.0 REQUIRED)

Proposed fix:

find_package(OpenSSL REQUIRED)

Thank you for your consideration!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions