Merge pull request #12 from code-rabi/fix-get-live-orders-accountid

fix: remove accountId parameter from get_live_orders tool

Author: NitayRabi

src/tool-definitions.ts

@@ -41,9 +41,7 @@ export const GetOrderStatusZodShape = {
   orderId: z.string()
 };
 
-export const GetLiveOrdersZodShape = {
-  accountId: z.string().optional()
-};
+export const GetLiveOrdersZodShape = {};
 
 export const ConfirmOrderZodShape = {
   replyId: z.string(),

src/tool-handlers.ts

@@ -455,7 +455,8 @@ export class ToolHandlers {
         await this.ensureAuth();
       }
 
-      const result = await this.context.ibClient.getOrders(input.accountId);
+      // Always fetch all orders (don't pass accountId as it causes API errors)
+      const result = await this.context.ibClient.getOrders();
       return {
         content: [
           {

src/tools.ts

@@ -86,7 +86,7 @@ export function registerTools(
   // Register get_live_orders tool
   server.tool(
     "get_live_orders",
-    "Get all live/open orders for monitoring and validation. Usage: `{}` to get all orders or `{ \"accountId\": \"<id>\" }` for a specific account. " +
+    "Get all live/open orders for monitoring and validation. Usage: `{}`. " +
     "This is the recommended way to validate that market orders were executed successfully after placing them.",
     GetLiveOrdersZodShape,
     async (args) => await handlers.getLiveOrders(args)

test/tool-handlers.test.ts

@@ -192,16 +192,17 @@ describe('ToolHandlers', () => {
       const result = await handlers.getLiveOrders({});
 
       expect(result.content).toBeDefined();
-      expect(mockIBClient.getOrders).toHaveBeenCalledWith(undefined);
+      expect(mockIBClient.getOrders).toHaveBeenCalledWith();
     });
 
-    it('should return orders for specific account', async () => {
+    it('should always fetch all orders without account parameter', async () => {
       const mockOrders = [{ orderId: '123', status: 'Working' }];
       mockIBClient.getOrders = vi.fn().mockResolvedValue(mockOrders);
 
-      const result = await handlers.getLiveOrders({ accountId: 'U12345' });
+      const result = await handlers.getLiveOrders({});
 
-      expect(mockIBClient.getOrders).toHaveBeenCalledWith('U12345');
+      expect(mockIBClient.getOrders).toHaveBeenCalledWith();
+      expect(result.content).toBeDefined();
     });
   });