Skip to content

Commit 17fb59b

Browse files
authored
refactor: display the right order for the temperature chart items (#188)
1 parent 277a14c commit 17fb59b

File tree

3 files changed

+16
-43
lines changed

3 files changed

+16
-43
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@code4ro/taskforce-fe-components",
3-
"version": "1.0.24",
3+
"version": "1.0.25",
44
"private": false,
55
"dependencies": {
66
"bulma": "^0.8.0",

src/components/temperature-chart/temperature-chart.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,13 @@ import format from "date-fns/format";
66
import fromUnixTime from "date-fns/fromUnixTime";
77

88
export const TemperatureChart = ({ results = [], title }) => {
9-
const yAxisData = results.map(item =>
9+
// NOTE: Because of the way the Axes are displayed, we need
10+
// to reverse the items order to show the original order
11+
const itemsListReversed = results.reverse();
12+
const yAxisData = itemsListReversed.map(item =>
1013
format(fromUnixTime(item.date), "dd.MM.yyyy / HH:mm")
1114
);
12-
const xAxisData = results.map(item => ({
15+
const xAxisData = itemsListReversed.map(item => ({
1316
value: item.temperature,
1417
itemStyle: { color: item.temperature > 37 ? "red" : "blue" }
1518
}));

src/components/temperature-chart/temperature-chart.stories.js

Lines changed: 10 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -5,46 +5,16 @@ import { TemperatureChart } from "./temperature-chart";
55
export default { title: "Temperature Chart" };
66

77
const results = [
8-
{
9-
id: "134",
10-
date: "1585409321",
11-
temperature: 36.6
12-
},
13-
{
14-
id: "136",
15-
date: "1585409421",
16-
temperature: 36
17-
},
18-
{
19-
id: "139",
20-
date: "1585409521",
21-
temperature: 38.6
22-
},
23-
{
24-
id: "140",
25-
date: "1585409621",
26-
temperature: 38.6
27-
},
28-
{
29-
id: "134",
30-
date: "1585409321",
31-
temperature: 36.6
32-
},
33-
{
34-
id: "136",
35-
date: "1585409421",
36-
temperature: 36
37-
},
38-
{
39-
id: "139",
40-
date: "1585409521",
41-
temperature: 38.6
42-
},
43-
{
44-
id: "140",
45-
date: "1585409621",
46-
temperature: 38.6
47-
}
8+
{ date: 1588710285, temperature: 35 },
9+
{ date: 1588710285, temperature: 36 },
10+
{ date: 1588710285, temperature: 38 },
11+
{ date: 1588710285, temperature: 39 },
12+
{ date: 1588710285, temperature: 36.6 },
13+
{ date: 1588709754, temperature: 38.2 },
14+
{ date: 1588708675, temperature: 38 },
15+
{ date: 1588277085, temperature: 37 },
16+
{ date: 1588276813, temperature: 36 },
17+
{ date: 1588017389, temperature: 38 }
4818
];
4919

5020
export const temperatureChart = () => <TemperatureChart results={results} />;

0 commit comments

Comments
 (0)