PWR083: Add benchmark

Author: alvrogd

Benchmark/src/CMakeLists.txt

@@ -21,3 +21,4 @@ endif()
 add_benchmark(PWR079)
 add_benchmark(PWR080)
 add_benchmark(PWR081)
+add_benchmark(PWR083)

Benchmark/src/PWR083.cpp

@@ -0,0 +1,37 @@
+#include "Benchmark.h"
+
+// Forward-declare the functions to benchmark
+extern "C" {
+void update_simulation_state_by_fixed_amount(const int *n, double *state);
+void update_simulation_state_by_fixed_amount_improved(const int *n,
+                                                      double *state);
+}
+
+constexpr int N = 1024 * 1024;
+
+#if OCB_ENABLE_Fortran
+
+static void FortranExampleBench(benchmark::State &state) {
+  auto array = OpenCatalog::CreateRandomVector<double>(N);
+
+  for (auto _ : state) {
+    update_simulation_state_by_fixed_amount(&N, array.data());
+    benchmark::DoNotOptimize(array);
+  }
+}
+
+static void FortranImprovedBench(benchmark::State &state) {
+  auto array = OpenCatalog::CreateRandomVector<double>(N);
+
+  for (auto _ : state) {
+    update_simulation_state_by_fixed_amount_improved(&N, array.data());
+    benchmark::DoNotOptimize(array);
+  }
+}
+
+// The improved benchmark prevents the runtime bug, while not incurring in any
+// performance penalty
+OC_BENCHMARK("PWR083 Fortran Example", FortranExampleBench);
+OC_BENCHMARK("PWR083 Fortran Improved", FortranImprovedBench);
+
+#endif

Checks/PWR083/benchmark/example.f90

@@ -0,0 +1,20 @@
+! PWR083: Match dummy and actual argument types in procedure calls
+
+! NOT-PWR068: External procedure used to demonstrate how compilers can't catch
+!             the type mismatch
+! NOT-PWR070: Explicit-shape arrays used for C-interoperability
+subroutine update_simulation_state_by_fixed_amount(n, state) bind(c)
+  use iso_c_binding, only: c_double, c_int
+  use iso_fortran_env, only: real32
+  implicit none
+
+  external :: update_simulation_state
+
+  integer(kind=c_int), intent(in) :: n
+  real(kind=c_double), dimension(n), intent(inout) :: state
+
+  real(kind=real32) :: numberSteps
+
+  numberSteps = 100
+  call update_simulation_state(numberSteps, n, state)
+end subroutine update_simulation_state_by_fixed_amount

Checks/PWR083/benchmark/simulation.f90

@@ -0,0 +1,17 @@
+! PWR083: Match dummy and actual argument types in procedure calls
+
+! NOT-PWR070: Explicit-shape arrays used for C-interoperability
+pure subroutine update_simulation_state(numberSteps, n, state)
+  use iso_c_binding, only: c_double, c_int
+  implicit none
+
+  integer, intent(in) :: numberSteps
+  integer(kind=c_int), intent(in) :: n
+  real(kind=c_double), dimension(n), intent(inout) :: state
+
+  integer(kind=c_int) :: i
+
+  do i = 1, n
+    state(i) = state(i) + numberSteps * 9.81_c_double
+  end do
+end subroutine update_simulation_state

Checks/PWR083/benchmark/solution.f90

@@ -0,0 +1,19 @@
+! PWR083: Match dummy and actual argument types in procedure calls
+
+! NOT-PWR068: External procedure used to demonstrate how compilers can't catch
+!             the type mismatch
+! NOT-PWR070: Explicit-shape arrays used for C-interoperability
+subroutine update_simulation_state_by_fixed_amount_improved(n, state) bind(c)
+  use iso_c_binding, only: c_double, c_int
+  implicit none
+
+  external :: update_simulation_state
+
+  integer(kind=c_int), intent(in) :: n
+  real(kind=c_double), dimension(n), intent(inout) :: state
+
+  integer :: numberSteps
+
+  numberSteps = 100
+  call update_simulation_state(numberSteps, n, state)
+end subroutine update_simulation_state_by_fixed_amount_improved