Replace floating-point constructors with valueOf (#4389)

shai-almog · web-flow · commit e74b11b0846b · 2026-01-07T07:54:51.000+02:00
diff --git a/.github/scripts/generate-quality-report.py b/.github/scripts/generate-quality-report.py
@@ -797,6 +797,7 @@ def main() -> None:
             "BC_UNCONFIRMED_CAST_OF_RETURN_VALUE",
             "CN_IDIOM_NO_SUPER_CALL",
             "DM_BOOLEAN_CTOR",
+            "DM_FP_NUMBER_CTOR",
             "DM_EXIT",
             "EI_EXPOSE_REP", 
             "EI_EXPOSE_REP2",
diff --git a/CodenameOne/src/com/codename1/io/JSONParser.java b/CodenameOne/src/com/codename1/io/JSONParser.java
@@ -838,10 +838,10 @@ public void stringToken(String tok) {
      */
     public void numericToken(double tok) {
         if (isStackHash()) {
-            getStackHash().put(currentKey, new Double(tok));
+            getStackHash().put(currentKey, Double.valueOf(tok));
             currentKey = null;
         } else {
-            getStackVec().add(new Double(tok));
+            getStackVec().add(Double.valueOf(tok));
         }
     }
 
diff --git a/CodenameOne/src/com/codename1/io/Preferences.java b/CodenameOne/src/com/codename1/io/Preferences.java
@@ -173,7 +173,7 @@ public static void set(String pref, long l) {
      * @param d    a number
      */
     public static void set(String pref, double d) {
-        set(pref, new Double(d));
+        set(pref, Double.valueOf(d));
     }
 
     /**
@@ -183,7 +183,7 @@ public static void set(String pref, double d) {
      * @param f    a number
      */
     public static void set(String pref, float f) {
-        set(pref, new Float(f));
+        set(pref, Float.valueOf(f));
     }
 
     /**
diff --git a/CodenameOne/src/com/codename1/javascript/JSObject.java b/CodenameOne/src/com/codename1/javascript/JSObject.java
@@ -531,7 +531,7 @@ public void set(String key, Object js) {
      * @param async True if you want this call to be asynchronous.
      */
     public void setInt(String key, int value, boolean async) {
-        set(key, new Double(value), async);
+        set(key, Double.valueOf(value), async);
     }
 
     /**
@@ -552,7 +552,7 @@ public void setInt(String key, int value) {
      * @param async True if you want this call to be asynchronous.
      */
     public void setDouble(String key, double value, boolean async) {
-        set(key, new Double(value), async);
+        set(key, Double.valueOf(value), async);
     }
 
     /**
@@ -615,7 +615,7 @@ public void set(int index, Object js) {
      * @param async True to make this call asynchronous.
      */
     public void setInt(int index, int value, boolean async) {
-        set(index, new Double(value), async);
+        set(index, Double.valueOf(value), async);
     }
 
     /**
@@ -636,7 +636,7 @@ public void setInt(int index, int value) {
      * @param async True to make this call asynchronous.
      */
     public void setDouble(int index, double value, boolean async) {
-        set(index, new Double(value), async);
+        set(index, Double.valueOf(value), async);
     }
 
     /**
diff --git a/CodenameOne/src/com/codename1/maps/MapComponent.java b/CodenameOne/src/com/codename1/maps/MapComponent.java
@@ -1107,11 +1107,11 @@ public Class[] getPropertyTypes() {
     public Object getPropertyValue(String name) {
         if (name.equals("latitude")) {
             Coord c = _map.projection().toWGS84(_center);
-            return new Double(c.getLatitude());
+            return Double.valueOf(c.getLatitude());
         }
         if (name.equals("longitude")) {
             Coord c = _map.projection().toWGS84(_center);
-            return new Double(c.getLongitude());
+            return Double.valueOf(c.getLongitude());
         }
         if (name.equals("zoom")) {
             return Integer.valueOf(getZoomLevel());
diff --git a/CodenameOne/src/com/codename1/ui/layouts/mig/AC.java b/CodenameOne/src/com/codename1/ui/layouts/mig/AC.java
@@ -450,7 +450,7 @@ public AC grow(float w) {
      * @return <code>this</code> so it is possible to chain calls. E.g. <code>new AxisConstraint().noGrid().gap().fill()</code>.
      */
     public AC grow(float w, int... indexes) {
-        Float gw = new Float(w);
+        Float gw = Float.valueOf(w);
         for (int i = indexes.length - 1; i >= 0; i--) {
             int ix = indexes[i];
             makeSize(ix);
@@ -527,7 +527,7 @@ public AC shrink(float w) {
      * @since 3.7.2
      */
     public AC shrink(float w, int... indexes) {
-        Float sw = new Float(w);
+        Float sw = Float.valueOf(w);
         for (int i = indexes.length - 1; i >= 0; i--) {
             int ix = indexes[i];
             makeSize(ix);
diff --git a/CodenameOne/src/com/codename1/ui/layouts/mig/CC.java b/CodenameOne/src/com/codename1/ui/layouts/mig/CC.java
@@ -333,7 +333,7 @@ public CC shrinkPrio(int... widthHeight) {
      * @return <code>this</code> so it is possible to chain calls. E.g. <code>new ComponentConstraint().noGrid().gap().fill()</code>.
      */
     public CC shrinkX(float w) {
-        hor.setShrink(new Float(w));
+        hor.setShrink(Float.valueOf(w));
         return this;
     }
 
@@ -560,7 +560,7 @@ public CC shrinkPrioY(int p) {
      * @return <code>this</code> so it is possible to chain calls. E.g. <code>new ComponentConstraint().noGrid().gap().fill()</code>.
      */
     public CC shrinkY(float w) {
-        ver.setShrink(new Float(w));
+        ver.setShrink(Float.valueOf(w));
         return this;
     }
 
diff --git a/CodenameOne/src/com/codename1/ui/layouts/mig/CodenameOneMiGComponentWrapper.java b/CodenameOne/src/com/codename1/ui/layouts/mig/CodenameOneMiGComponentWrapper.java
@@ -133,7 +133,7 @@ public final float getPixelUnitFactor(boolean isHor) {
 
                 Float s = isHor ? PlatformDefaults.getHorizontalScaleFactor() : PlatformDefaults.getVerticalScaleFactor();
                 if (s == null)
-                    s = new Float(1.0f);
+                    s = Float.valueOf(1.0f);
                 return s * (isHor ? getHorizontalScreenDPI() : getVerticalScreenDPI()) / (float) PlatformDefaults.getDefaultDPI();
 
             default:
diff --git a/CodenameOne/src/com/codename1/ui/layouts/mig/ConstraintParser.java b/CodenameOne/src/com/codename1/ui/layouts/mig/ConstraintParser.java
@@ -898,10 +898,10 @@ public static CC parseComponentConstraint(String s) {
                     }
 
                     if (part.equals("dock center")) {
-                        cc.getHorizontal().setGrow(new Float(100f));
-                        cc.getVertical().setGrow(new Float(100f));
-                        cc.setPushX(new Float(100f));
-                        cc.setPushY(new Float(100f));
+                        cc.getHorizontal().setGrow(Float.valueOf(100f));
+                        cc.getVertical().setGrow(Float.valueOf(100f));
+                        cc.setPushX(Float.valueOf(100f));
+                        cc.setPushY(Float.valueOf(100f));
                         continue;
                     }
                 }
@@ -1067,7 +1067,7 @@ private static int parseSpan(String s) {
     }
 
     private static Float parseFloat(String s, Float nullVal) {
-        return s.length() > 0 ? new Float(Float.parseFloat(s)) : nullVal;
+        return s.length() > 0 ? Float.valueOf(Float.parseFloat(s)) : nullVal;
     }
 
     /**
diff --git a/CodenameOne/src/com/codename1/ui/layouts/mig/ResizeConstraint.java b/CodenameOne/src/com/codename1/ui/layouts/mig/ResizeConstraint.java
@@ -39,7 +39,7 @@
  * grow compared to other entities.
  */
 final class ResizeConstraint {
-    static final Float WEIGHT_100 = new Float(100);
+    static final Float WEIGHT_100 = Float.valueOf(100);
 
     /**
      * How flexilble the entity should be, relative to other entities, when it comes to growing. <code>null</code> or
diff --git a/CodenameOne/src/com/codename1/ui/plaf/Style.java b/CodenameOne/src/com/codename1/ui/plaf/Style.java
@@ -2475,8 +2475,8 @@ private void setBackgroundAlignment(byte backgroundAlignment, boolean override)
      */
     Object[] getBackgroundGradient() {
         if (backgroundGradient == null) {
-            Float c = new Float(0.5f);
-            backgroundGradient = new Object[]{Integer.valueOf(0xffffff), Integer.valueOf(0), c, c, new Float(1)};
+            Float c = Float.valueOf(0.5f);
+            backgroundGradient = new Object[]{Integer.valueOf(0xffffff), Integer.valueOf(0), c, c, Float.valueOf(1)};
         }
         return backgroundGradient;
     }
@@ -2549,7 +2549,7 @@ public void setBackgroundGradientRelativeX(float backgroundGradientRelativeX, bo
             return;
         }
         if (((Float) getBackgroundGradient()[2]).floatValue() != backgroundGradientRelativeX) {
-            getBackgroundGradient()[2] = new Float(backgroundGradientRelativeX);
+            getBackgroundGradient()[2] = Float.valueOf(backgroundGradientRelativeX);
             if (!override) {
                 modifiedFlag |= BACKGROUND_GRADIENT_MODIFIED;
             }
@@ -2572,7 +2572,7 @@ public void setBackgroundGradientRelativeY(float backgroundGradientRelativeY, bo
             return;
         }
         if (((Float) getBackgroundGradient()[3]).floatValue() != backgroundGradientRelativeY) {
-            getBackgroundGradient()[3] = new Float(backgroundGradientRelativeY);
+            getBackgroundGradient()[3] = Float.valueOf(backgroundGradientRelativeY);
             if (!override) {
                 modifiedFlag |= BACKGROUND_GRADIENT_MODIFIED;
             }
@@ -2596,7 +2596,7 @@ public void setBackgroundGradientRelativeSize(float backgroundGradientRelativeSi
             return;
         }
         if (((Float) getBackgroundGradient()[4]).floatValue() != backgroundGradientRelativeSize) {
-            getBackgroundGradient()[4] = new Float(backgroundGradientRelativeSize);
+            getBackgroundGradient()[4] = Float.valueOf(backgroundGradientRelativeSize);
             if (!override) {
                 modifiedFlag |= BACKGROUND_GRADIENT_MODIFIED;
             }
diff --git a/CodenameOne/src/com/codename1/ui/plaf/UIManager.java b/CodenameOne/src/com/codename1/ui/plaf/UIManager.java
@@ -1946,7 +1946,7 @@ Style createStyle(String id, String prefix, boolean selected) {
                     Object[] a = new Object[5];
                     System.arraycopy(backgroundGradient, 0, a, 0, backgroundGradient.length);
                     backgroundGradient = a;
-                    backgroundGradient[4] = new Float(1);
+                    backgroundGradient[4] = Float.valueOf(1);
                 }
                 style.setBackgroundGradient(backgroundGradient);
             }
diff --git a/CodenameOne/src/com/codename1/ui/spinner/NumericSpinner.java b/CodenameOne/src/com/codename1/ui/spinner/NumericSpinner.java
@@ -126,7 +126,7 @@ public double getValue() {
     public void setValue(double value) {
         this.value = value;
         if (spin != null) {
-            ((SpinnerNumberModel) spin.getModel()).setValue(new Double(value));
+            ((SpinnerNumberModel) spin.getModel()).setValue(Double.valueOf(value));
         }
     }
 
@@ -177,16 +177,16 @@ public String[] getPropertyTypeNames() {
      */
     public Object getPropertyValue(String name) {
         if (name.equals("min")) {
-            return new Double(min);
+            return Double.valueOf(min);
         }
         if (name.equals("max")) {
-            return new Double(max);
+            return Double.valueOf(max);
         }
         if (name.equals("value")) {
-            return new Double(getValue());
+            return Double.valueOf(getValue());
         }
         if (name.equals("step")) {
-            return new Double(step);
+            return Double.valueOf(step);
         }
         return null;
     }
diff --git a/CodenameOne/src/com/codename1/ui/spinner/Spinner.java b/CodenameOne/src/com/codename1/ui/spinner/Spinner.java
@@ -206,7 +206,7 @@ public Component getListCellRendererComponent(List list, Object value, int index
                 return super.getListCellRendererComponent(list, value, index, isSelected);
             }
         });
-        s.setRenderingPrototype(new Double(max * 10));
+        s.setRenderingPrototype(Double.valueOf(max * 10));
         return s;
     }
 
@@ -531,7 +531,7 @@ public void keyReleased(int code) {
                                 val < ((SpinnerNumberModel) getModel()).getMin()) {
                             return;
                         }
-                        setValue(new Double(val));
+                        setValue(Double.valueOf(val));
                     } else {
                         int val = Integer.parseInt(t);
                         if (val > ((SpinnerNumberModel) getModel()).getMax() ||
diff --git a/CodenameOne/src/com/codename1/ui/spinner/SpinnerNumberModel.java b/CodenameOne/src/com/codename1/ui/spinner/SpinnerNumberModel.java
@@ -93,7 +93,7 @@ public SpinnerNumberModel(double min, double max, double currentValue, double st
 
     Object getValue() {
         if (realValues) {
-            return new Double(currentValue);
+            return Double.valueOf(currentValue);
         }
         return Integer.valueOf((int) currentValue);
     }
@@ -115,7 +115,7 @@ void setValue(Object value) {
      */
     public Object getItemAt(int index) {
         if (realValues) {
-            return new Double(min + step * index);
+            return Double.valueOf(min + step * index);
         }
         return Integer.valueOf((int) (min + step * index));
     }
diff --git a/CodenameOne/src/com/codename1/ui/util/Resources.java b/CodenameOne/src/com/codename1/ui/util/Resources.java
@@ -1576,8 +1576,8 @@ Hashtable loadTheme(String id, boolean newerVersion) throws IOException {
                     case 0xF6:
                         // Vertical Linear Gradient
                     case 0xF7:
-                        Float c = new Float(0.5f);
-                        theme.put(key + Style.BACKGROUND_GRADIENT, new Object[]{Integer.valueOf(input.readInt()), Integer.valueOf(input.readInt()), c, c, new Float(1)});
+                        Float c = Float.valueOf(0.5f);
+                        theme.put(key + Style.BACKGROUND_GRADIENT, new Object[]{Integer.valueOf(input.readInt()), Integer.valueOf(input.readInt()), c, c, Float.valueOf(1)});
                         break;
 
                     // Radial Gradient
@@ -1592,9 +1592,9 @@ Hashtable loadTheme(String id, boolean newerVersion) throws IOException {
                         }
                         theme.put(key + Style.BACKGROUND_GRADIENT, new Object[]{Integer.valueOf(c1),
                                 Integer.valueOf(c2),
-                                new Float(f1),
-                                new Float(f2),
-                                new Float(radialSize)});
+                                Float.valueOf(f1),
+                                Float.valueOf(f2),
+                                Float.valueOf(radialSize)});
                         break;
                     default:
                         break;
@@ -1641,16 +1641,16 @@ Hashtable loadTheme(String id, boolean newerVersion) throws IOException {
                     theme.put(key, new Object[]{
                             Integer.valueOf(input.readInt()),
                             Integer.valueOf(input.readInt()),
-                            new Float(input.readFloat()),
-                            new Float(input.readFloat())
+                            Float.valueOf(input.readFloat()),
+                            Float.valueOf(input.readFloat())
                     });
                 } else {
                     theme.put(key, new Object[]{
                             Integer.valueOf(input.readInt()),
                             Integer.valueOf(input.readInt()),
-                            new Float(input.readFloat()),
-                            new Float(input.readFloat()),
-                            new Float(input.readFloat())
+                            Float.valueOf(input.readFloat()),
+                            Float.valueOf(input.readFloat()),
+                            Float.valueOf(input.readFloat())
                     });
                 }
                 continue;
diff --git a/CodenameOne/src/com/codename1/ui/util/UIBuilder.java b/CodenameOne/src/com/codename1/ui/util/UIBuilder.java
@@ -863,11 +863,11 @@ private Object readCustomPropertyValue(DataInputStream in, Class type, String ty
         }
 
         if (type == Double.class) {
-            return new Double(in.readDouble());
+            return Double.valueOf(in.readDouble());
         }
 
         if (type == Float.class) {
-            return new Float(in.readFloat());
+            return Float.valueOf(in.readFloat());
         }
 
         if (type == Byte.class) {

Original file line number	Diff line number	Diff line change
`@@ -838,10 +838,10 @@ public void stringToken(String tok) {`
`838`	`838`	`*/`
`839`	`839`	`public void numericToken(double tok) {`
`840`	`840`	`if (isStackHash()) {`
`841`		`- getStackHash().put(currentKey, new Double(tok));`
	`841`	`+ getStackHash().put(currentKey, Double.valueOf(tok));`
`842`	`842`	`currentKey = null;`
`843`	`843`	`} else {`
`844`		`- getStackVec().add(new Double(tok));`
	`844`	`+ getStackVec().add(Double.valueOf(tok));`
`845`	`845`	`}`
`846`	`846`	`}`
`847`	`847`
Original file line number	Diff line number	Diff line change
`@@ -1107,11 +1107,11 @@ public Class[] getPropertyTypes() {`
`1107`	`1107`	`public Object getPropertyValue(String name) {`
`1108`	`1108`	`if (name.equals("latitude")) {`
`1109`	`1109`	`Coord c = _map.projection().toWGS84(_center);`
`1110`		`- return new Double(c.getLatitude());`
	`1110`	`+ return Double.valueOf(c.getLatitude());`
`1111`	`1111`	`}`
`1112`	`1112`	`if (name.equals("longitude")) {`
`1113`	`1113`	`Coord c = _map.projection().toWGS84(_center);`
`1114`		`- return new Double(c.getLongitude());`
	`1114`	`+ return Double.valueOf(c.getLongitude());`
`1115`	`1115`	`}`
`1116`	`1116`	`if (name.equals("zoom")) {`
`1117`	`1117`	`return Integer.valueOf(getZoomLevel());`
Original file line number	Diff line number	Diff line change
`@@ -898,10 +898,10 @@ public static CC parseComponentConstraint(String s) {`
`898`	`898`	`}`
`899`	`899`
`900`	`900`	`if (part.equals("dock center")) {`
`901`		`- cc.getHorizontal().setGrow(new Float(100f));`
`902`		`- cc.getVertical().setGrow(new Float(100f));`
`903`		`- cc.setPushX(new Float(100f));`
`904`		`- cc.setPushY(new Float(100f));`
	`901`	`+ cc.getHorizontal().setGrow(Float.valueOf(100f));`
	`902`	`+ cc.getVertical().setGrow(Float.valueOf(100f));`
	`903`	`+ cc.setPushX(Float.valueOf(100f));`
	`904`	`+ cc.setPushY(Float.valueOf(100f));`
`905`	`905`	`continue;`
`906`	`906`	`}`
`907`	`907`	`}`
`@@ -1067,7 +1067,7 @@ private static int parseSpan(String s) {`
`1067`	`1067`	`}`
`1068`	`1068`
`1069`	`1069`	`private static Float parseFloat(String s, Float nullVal) {`
`1070`		`- return s.length() > 0 ? new Float(Float.parseFloat(s)) : nullVal;`
	`1070`	`+ return s.length() > 0 ? Float.valueOf(Float.parseFloat(s)) : nullVal;`
`1071`	`1071`	`}`
`1072`	`1072`
`1073`	`1073`	`/**`