Add more logging and some cleanup

Author: EhabY

src/api/coderApi.ts

@@ -177,11 +177,14 @@ export class CoderApi extends Api implements vscode.Disposable {
 			const socketsToReconnect = [...this.reconnectingSockets].filter(
 				(socket) => socket.state === ConnectionState.DISCONNECTED,
 			);
-			this.output.debug(
-				`Configuration changed, ${socketsToReconnect.length}/${this.reconnectingSockets.size} socket(s) in DISCONNECTED state`,
-			);
-			for (const socket of socketsToReconnect) {
-				socket.reconnect();
+			if (socketsToReconnect.length) {
+				this.output.debug(
+					`Configuration changed, ${socketsToReconnect.length}/${this.reconnectingSockets.size} socket(s) in DISCONNECTED state`,
+				);
+				for (const socket of socketsToReconnect) {
+					this.output.debug(`Reconnecting WebSocket: ${socket.url}`);
+					socket.reconnect();
+				}
 			}
 		});
 	}

src/inbox.ts

@@ -50,11 +50,6 @@ export class Inbox implements vscode.Disposable {
 			logger.info("Listening to Coder Inbox");
 		});
 
-		socket.addEventListener("error", () => {
-			// Errors are already logged internally
-			inbox.dispose();
-		});
-
 		socket.addEventListener("message", (data) => {
 			if (data.parseError) {
 				logger.error("Failed to parse inbox message", data.parseError);

src/websocket/reconnectingWebSocket.ts

@@ -93,12 +93,7 @@ function reduceState(
 			}
 
 		case "DISPOSE":
-			switch (state) {
-				case ConnectionState.DISPOSED:
-					return state;
-				default:
-					return ConnectionState.DISPOSED;
-			}
+			return ConnectionState.DISPOSED;
 	}
 }
 
@@ -172,7 +167,7 @@ export class ReconnectingWebSocket<
 		this.#onDispose = onDispose;
 	}
 
-	static async create<TData>(
+	public static async create<TData>(
 		socketFactory: SocketFactory<TData>,
 		logger: Logger,
 		options: ReconnectingWebSocketOptions,
@@ -190,14 +185,14 @@ export class ReconnectingWebSocket<
 		return instance;
 	}
 
-	get url(): string {
+	public get url(): string {
 		return this.#currentSocket?.url ?? "";
 	}
 
 	/**
 	 * Returns the current connection state.
 	 */
-	get state(): ConnectionState {
+	public get state(): ConnectionState {
 		return this.#state;
 	}
 
@@ -214,14 +209,14 @@ export class ReconnectingWebSocket<
 		return url.pathname + url.search;
 	}
 
-	addEventListener<TEvent extends WebSocketEventType>(
+	public addEventListener<TEvent extends WebSocketEventType>(
 		event: TEvent,
 		callback: EventHandler<TData, TEvent>,
 	): void {
 		this.#eventHandlers[event].add(callback);
 	}
 
-	removeEventListener<TEvent extends WebSocketEventType>(
+	public removeEventListener<TEvent extends WebSocketEventType>(
 		event: TEvent,
 		callback: EventHandler<TData, TEvent>,
 	): void {
@@ -232,7 +227,7 @@ export class ReconnectingWebSocket<
 	 * Force an immediate reconnection attempt.
 	 * Resumes the socket if previously disconnected via disconnect().
 	 */
-	reconnect(): void {
+	public reconnect(): void {
 		if (this.#state === ConnectionState.DISPOSED) {
 			return;
 		}
@@ -254,14 +249,14 @@ export class ReconnectingWebSocket<
 	/**
 	 * Temporarily disconnect the socket. Can be resumed via reconnect().
 	 */
-	disconnect(code?: number, reason?: string): void {
+	public disconnect(code?: number, reason?: string): void {
 		if (!this.#dispatch({ type: "DISCONNECT" })) {
 			return;
 		}
 		this.clearCurrentSocket(code, reason);
 	}
 
-	close(code?: number, reason?: string): void {
+	public close(code?: number, reason?: string): void {
 		if (this.#state === ConnectionState.DISPOSED) {
 			return;
 		}

src/workspace/workspacesProvider.ts

@@ -101,10 +101,6 @@ export class WorkspaceProvider
 	 * logged in or the query fails.
 	 */
 	private async fetch(): Promise<WorkspaceTreeItem[]> {
-		this.logger.debug(
-			`Fetching workspaces: ${this.getWorkspacesQuery || "no filter"}...`,
-		);
-
 		// If there is no URL configured, assume we are logged out.
 		const url = this.client.getAxiosInstance().defaults.baseURL;
 		if (!url) {