fix(review): catch invalid plugin configs per-server, strengthen empty command validation

- Wrap pluginConfigToClaudeConfig in try-catch per server in createMcpRegistry
  so one bad plugin config doesn't crash the entire registry
- Strengthen doctor command validation to catch empty string and empty array
- Update tests: malformed plugin configs are now silently skipped, not thrown

Author: codewithkenzo

src/cli/doctor/checks/mcp.ts

@@ -33,7 +33,7 @@ export async function getUserMcpInfo(): Promise<McpServerInfo[]> {
       valid = false
       error = "Invalid config: not an object"
     } else if (config.type === "stdio" || (!config.type && !config.url)) {
-      if (!config.command) {
+      if (!config.command || (Array.isArray(config.command) && config.command.length === 0) || config.command === "") {
         valid = false
         error = "Missing required field: command"
       }

src/features/mcp-registry/service.test.ts

@@ -109,33 +109,35 @@ describe("createMcpRegistry", () => {
     expect(registry.effectiveServersByName.hybrid?.transport).toBe("stdio")
   })
 
-  test("throws for malformed plugin remote config missing url", () => {
-    // #given / #when / #then
-    expect(() =>
-      createMcpRegistry({
-        pluginServers: {
-          broken: {
-            type: "remote",
-            // Intentionally malformed to verify runtime guard.
-            url: "",
-          },
+  test("skips malformed plugin remote config missing url", () => {
+    // #given / #when
+    const registry = createMcpRegistry({
+      pluginServers: {
+        broken: {
+          type: "remote",
+          // Intentionally malformed — should be silently skipped.
+          url: "",
         },
-      })
-    ).toThrow(/missing url/)
+      },
+    })
+
+    // #then
+    expect(registry.effectiveServers).toHaveLength(0)
   })
 
-  test("throws for malformed plugin local config with empty command", () => {
-    // #given / #when / #then
-    expect(() =>
-      createMcpRegistry({
-        pluginServers: {
-          broken: {
-            type: "local",
-            command: [],
-          },
+  test("skips malformed plugin local config with empty command", () => {
+    // #given / #when
+    const registry = createMcpRegistry({
+      pluginServers: {
+        broken: {
+          type: "local",
+          command: [],
         },
-      })
-    ).toThrow(/empty command array/)
+      },
+    })
+
+    // #then
+    expect(registry.effectiveServers).toHaveLength(0)
   })
 })
 

src/features/mcp-registry/service.ts

@@ -116,17 +116,21 @@ export function createMcpRegistry(input: CreateMcpRegistryInput): McpRegistryRes
   }
 
   for (const [name, config] of Object.entries(input.pluginServers ?? {})) {
-    const claudeConfig = pluginConfigToClaudeConfig(config)
+    try {
+      const claudeConfig = pluginConfigToClaudeConfig(config)
 
-    allServers.push({
-      name,
-      source: "plugin",
-      scope: "plugin",
-      precedence: SOURCE_PRECEDENCE.plugin,
-      transport: inferTransport(claudeConfig),
-      config: claudeConfig,
-      contextName: "plugin",
-    })
+      allServers.push({
+        name,
+        source: "plugin",
+        scope: "plugin",
+        precedence: SOURCE_PRECEDENCE.plugin,
+        transport: inferTransport(claudeConfig),
+        config: claudeConfig,
+        contextName: "plugin",
+      })
+    } catch {
+      // Skip plugin servers with invalid config (missing command/url)
+    }
   }
 
   allServers.push(...fromSkills(input.skills ?? []))