chore: remove console.log statements from src/#16
Closed
codewithkenzo wants to merge 1 commit intomainfrom
Closed
Conversation
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA). To sign the CLA, please comment on this PR with: This is a one-time requirement. Once signed, all your future contributions will be automatically accepted. I have read the CLA Document and I hereby sign the CLA Kenzo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Owner
Author
|
I have read the CLA Document and I hereby sign the CLA |
Owner
Author
|
Superseded by v4 branch — console.log cleanup included there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed 6 debug console statements from 4 files:
Scout-detected cleanup.
Greptile Overview
Greptile Summary
Cleanup PR removing 6 debug console statements from 4 files across CLI, hooks, and tools directories.
Changes:
src/cli/run/runner.ts:55- Removed session ID log (session info still available via other outputs)src/hooks/comment-checker/downloader.ts:130,168- Removed download progress messages (debugLog still active via env var)src/tools/ast-grep/downloader.ts:82,108- Removed download progress messages (error logs remain)src/tools/system-notify/utils.ts:18- Removed debug message for missing/proc/version(expected on non-WSL Linux)All removed logs were either redundant, debug-level, or superseded by existing error handling. No behavioral changes or edge case impacts.
Confidence Score: 5/5
Important Files Changed
Sequence Diagram
sequenceDiagram participant User participant CLI as CLI Runner participant Downloader as Binary Downloaders participant Utils as System Utils Note over CLI,Utils: Console.log statements removed from all paths User->>CLI: bunx oh-my-opencode run CLI->>CLI: createOpencode() CLI->>CLI: session.create() Note over CLI: Removed: console.log(Session ID) CLI->>User: Continue execution silently alt Binary Download Needed User->>Downloader: ensureAstGrepBinary() Downloader->>Downloader: downloadAstGrep() Note over Downloader: Removed: "Downloading..." & "ready" logs Downloader-->>User: Return binary path (silent) User->>Downloader: ensureCommentCheckerBinary() Downloader->>Downloader: downloadCommentChecker() Note over Downloader: Removed: "Downloading..." & "ready" logs Downloader-->>User: Return binary path (silent) end alt Platform Detection User->>Utils: detectPlatform() Utils->>Utils: readFileSync("/proc/version") Note over Utils: Removed: console.debug on error Utils-->>User: Return platform type (silent) end