[astro-purgecss] new css filename is not replaced in js files

[leifmarcus]

Describe the bug
Old css filenames will be still part of the js files in the dist folder. As Astro builds the pages using vite in the background, the css filenames will be also inside the __vite__mapDeps.

To Reproduce
I created an Astro setup on Stackblitz: https://stackblitz.com/edit/astro-purge-css-ttdz5pkh.
There, you can find an outdated css filename inside the generated OtherComponent.<hash>.js file in the dist folder after building.

1. Go to Stackblitz
2. run npm run build if it didn’t on startup
3. Open the OtherComponent.<hash>.js file in the dist/_astro folder.
4. See that there is a index.<hash>.css file, that was not replaced with the new filename.

Expected behavior
The css filenames should also be replaced inside the js files in the build output.

Screenshots
Screenshot of a file, that contains a link to a css file, that does not exist anymore in the dist folder.

Additional context
Astro Version: 5.16.1
Astro PurgeCSS: 7.0.2

[leifmarcus]

Currently, in the integration, the filenames are only replaced in the pages, returned from Astro. In order to also replace filenames in js files using a glob pattern

// Node: https://nodejs.org/api/fs.html#fspromisesglobpattern-options
// or using a glob library: https://www.npmjs.com/package/glob

import { glob } from 'node:fs/promises';

for await (const entry of glob(`${outDir}/**/*.js`)) {
  // replace filenames in entry the same way as in html files
  // considering, that the filepaths might not start with a /
}

[mhdcodes]

Hey @leifmarcus I’m actually aware of this issue. It’s more of a limitation than a bug, because if we update the CSS filenames inside the JS, the JS files also get a new hash and need to be renamed as well, which creates a circular loop. I’m thinking the best approach is to use the solution proposed in this comment

this is the only reasonable approach I see for now

[leifmarcus]

I see, didn’t think of the js file hashes. In that case, The best case would be a better bundling from Astro 😄

[mhdcodes]

I see, didn’t think of the js file hashes. In that case, The best case would be a better bundling from Astro 😄

yeah, thanks mate I will keep this open in case somebody want's to add to this issue.