From 86b7b48d96000ef3b4d53a16f9c5a8fede92c59a Mon Sep 17 00:00:00 2001 From: Kaivan Kamali Date: Wed, 9 Jul 2025 11:01:15 -0400 Subject: [PATCH 1/2] Adding env var for deployment_name --- .../langchain/llms/standard_langchain_llm_factory.py | 3 ++- .../run_context/langchain/util/api_key_error_check.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/neuro_san/internals/run_context/langchain/llms/standard_langchain_llm_factory.py b/neuro_san/internals/run_context/langchain/llms/standard_langchain_llm_factory.py index cbab9b1d9..e5885ec87 100644 --- a/neuro_san/internals/run_context/langchain/llms/standard_langchain_llm_factory.py +++ b/neuro_san/internals/run_context/langchain/llms/standard_langchain_llm_factory.py @@ -142,7 +142,8 @@ def create_base_chat_model(self, config: Dict[str, Any], # Azure-specific azure_endpoint=self.get_value_or_env(config, "azure_endpoint", "AZURE_OPENAI_ENDPOINT"), - deployment_name=config.get("deployment_name"), + deployment_name=self.get_value_or_env(config, "deployment_name", + "AZURE_OPENAI_DEPLOYMENT_NAME"), openai_api_version=self.get_value_or_env(config, "openai_api_version", "OPENAI_API_VERSION"), diff --git a/neuro_san/internals/run_context/langchain/util/api_key_error_check.py b/neuro_san/internals/run_context/langchain/util/api_key_error_check.py index 62c404a4d..fa6b5528b 100644 --- a/neuro_san/internals/run_context/langchain/util/api_key_error_check.py +++ b/neuro_san/internals/run_context/langchain/util/api_key_error_check.py @@ -27,7 +27,7 @@ "Connection error"], "OPENAI_API_VERSION": ["validation error", "api_version", "OPENAI_API_VERSION", "Error code: 404", "Resource not found"], - "deployment_name": ["Error code: 404", "Resource not found", "API deployment for this resource does not exist"], + "AZURE_OPENAI_DEPLOYMENT_NAME": ["Error code: 404", "Resource not found", "API deployment for this resource does not exist"], } From cabc2f8ad18d0396da212969316a60f172e0a1d0 Mon Sep 17 00:00:00 2001 From: Kaivan Kamali Date: Wed, 9 Jul 2025 12:28:14 -0400 Subject: [PATCH 2/2] Fixed lint issue --- .../run_context/langchain/util/api_key_error_check.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/neuro_san/internals/run_context/langchain/util/api_key_error_check.py b/neuro_san/internals/run_context/langchain/util/api_key_error_check.py index fa6b5528b..143fa7e7e 100644 --- a/neuro_san/internals/run_context/langchain/util/api_key_error_check.py +++ b/neuro_san/internals/run_context/langchain/util/api_key_error_check.py @@ -27,7 +27,8 @@ "Connection error"], "OPENAI_API_VERSION": ["validation error", "api_version", "OPENAI_API_VERSION", "Error code: 404", "Resource not found"], - "AZURE_OPENAI_DEPLOYMENT_NAME": ["Error code: 404", "Resource not found", "API deployment for this resource does not exist"], + "AZURE_OPENAI_DEPLOYMENT_NAME": ["Error code: 404", "Resource not found", + "API deployment for this resource does not exist"], }