Tests and full coverage for Mimeparse::parseMimeType

Author: Ben Ramsey

src/Bitworking/Mimeparse.php

@@ -27,6 +27,7 @@ class Mimeparse
      *
      * @param string $mimeType
      * @return array ($type, $subtype, $params)
+     * @throws UnexpectedValueException when $mimeType does not include a valid subtype
      */
     public static function parseMimeType($mimeType)
     {
@@ -51,7 +52,7 @@ public static function parseMimeType($mimeType)
         list($type, $subtype) = explode('/', $fullType);
 
         if (!$subtype) {
-            throw (new \Exception('malformed mime type'));
+            throw new \UnexpectedValueException('malformed mime type');
         }
 
         return array(trim($type), trim($subtype), $params);

tests/Bitworking/MimeparseTest.php

@@ -5,6 +5,7 @@ class MimeparseTest extends \PHPUnit_Framework_TestCase
 {
     /**
      * @covers Bitworking\Mimeparse::parseMediaRange
+     * @covers Bitworking\Mimeparse::parseMimeType
      */
     public function testParseMediaRange()
     {
@@ -35,6 +36,16 @@ public function testParseMediaRange()
         ), Mimeparse::parseMediaRange(' *; q=.2'));
     }
 
+    /**
+     * @covers Bitworking\Mimeparse::parseMimeType
+     * @expectedException UnexpectedValueException
+     * @expectedExceptionMessage malformed mime type
+     */
+    public function testParseMimeTypeWithMalformedMimeType()
+    {
+        $parsed = Mimeparse::parseMimeType('application/;q=1');
+    }
+
     /**
      * @covers Bitworking\Mimeparse::quality
      */