Probably ineffective code in internal/mkcw/archive_test.go:TestArchive

[mtrmac]

• (Original motivation) The linter reports tautological condition: nil == nil after the “bail now if we got an error we didn't expect” code, the if err == nil is always true
• It turns out ignoreChainRetrievalErrors is only consulted within the error handling, it is not an input to anything
• If IgnoreAttestationErrors, the errors are turned into warnings, so they should never be reported to the caller; the test sees them, that’s a problem, regardless of the ignore… values
• For any kind of completely unexpected error type, the test just returns and does not fail. This might be intentional but I see no evidence for it.

Cc: @nalind

[nalind]

How did you get the linter to warn about this? I don't see it when I use make lint, even when swapping in the linter configurations used by podman and skopeo, so I don't think our CI would be able to tell if it was resolved.

[mtrmac]

This was in my IDE; the backend is probably some smarter version of gopls check $(find internal/mkcw -name '*.go')