Skip to content

Commit 51c0d0d

Browse files
committed
tests: Skip broken vsock/TSI tests on macOS for now
Signed-off-by: Matej Hrica <mhrica@redhat.com>
1 parent 495e288 commit 51c0d0d

File tree

3 files changed

+15
-3
lines changed

3 files changed

+15
-3
lines changed

tests/test_cases/src/test_tsi_tcp_guest_connect.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,15 @@ mod host {
2121

2222
use crate::common::setup_fs_and_enter;
2323
use crate::{krun_call, krun_call_u32};
24-
use crate::{Test, TestSetup};
24+
use crate::{ShouldRun, Test, TestSetup};
2525
use krun_sys::*;
2626
use std::thread;
2727

2828
impl Test for TestTsiTcpGuestConnect {
29+
fn should_run(&self) -> ShouldRun {
30+
ShouldRun::yes_unless_macos("broken on macOS")
31+
}
32+
2933
fn start_vm(self: Box<Self>, test_setup: TestSetup) -> anyhow::Result<()> {
3034
let listener = self.tcp_tester.create_server_socket();
3135
thread::spawn(move || self.tcp_tester.run_server(listener));

tests/test_cases/src/test_tsi_tcp_guest_listen.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,18 @@ impl TestTsiTcpGuestListen {
1919
mod host {
2020
use super::*;
2121
use crate::common::setup_fs_and_enter;
22-
use crate::{krun_call, krun_call_u32, Test, TestSetup};
22+
use crate::{krun_call, krun_call_u32, ShouldRun, Test, TestSetup};
2323
use krun_sys::*;
2424
use std::ffi::CString;
2525
use std::ptr::null;
2626
use std::thread;
2727
use std::time::Duration;
2828

2929
impl Test for TestTsiTcpGuestListen {
30+
fn should_run(&self) -> ShouldRun {
31+
ShouldRun::yes_unless_macos("broken on macOS")
32+
}
33+
3034
fn start_vm(self: Box<Self>, test_setup: TestSetup) -> anyhow::Result<()> {
3135
unsafe {
3236
thread::spawn(move || {

tests/test_cases/src/test_vsock_guest_connect.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ mod host {
3535

3636
use crate::common::setup_fs_and_enter;
3737
use crate::{krun_call, krun_call_u32};
38-
use crate::{Test, TestSetup};
38+
use crate::{ShouldRun, Test, TestSetup};
3939
use krun_sys::*;
4040
use std::ffi::CString;
4141
use std::io::Write;
@@ -55,6 +55,10 @@ mod host {
5555
}
5656

5757
impl Test for TestVsockGuestConnect {
58+
fn should_run(&self) -> ShouldRun {
59+
ShouldRun::yes_unless_macos("broken on macOS")
60+
}
61+
5862
fn start_vm(self: Box<Self>, test_setup: TestSetup) -> anyhow::Result<()> {
5963
let sock_path = test_setup.tmp_dir.join("test.sock");
6064
let sock_path_cstr = CString::new(sock_path.as_os_str().as_bytes())?;

0 commit comments

Comments
 (0)