Skip to content

Commit 12dc764

Browse files
committed
bug: do not need to update flux policy directly
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
1 parent 2644ead commit 12dc764

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

manifests/base/manager/manager.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ spec:
2323
containers:
2424
- name: manager
2525
image: ghcr.io/kubeflow/trainer/trainer-controller-manager
26-
# Uncomment for local development with kind
27-
# imagePullPolicy: Never
2826
securityContext:
2927
readOnlyRootFilesystem: true
3028
allowPrivilegeEscalation: false

pkg/runtime/framework/plugins/flux/flux.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ func (f *Flux) Validate(_ context.Context, runtimeInfo *runtime.Info, _, newJobO
123123
// EnforceMLPolicy updates the JobSet
124124
func (f *Flux) EnforceMLPolicy(info *runtime.Info, trainJob *trainer.TrainJob) error {
125125
if info == nil || info.RuntimePolicy.MLPolicySource == nil || info.RuntimePolicy.MLPolicySource.Flux == nil {
126-
fmt.Println("FluxPolicySource is nil.")
127126
return nil
128127
}
129128

@@ -209,7 +208,7 @@ func (f *Flux) EnforceMLPolicy(info *runtime.Info, trainJob *trainer.TrainJob) e
209208
func (f *Flux) Build(ctx context.Context, info *runtime.Info, trainJob *trainer.TrainJob) ([]apiruntime.ApplyConfiguration, error) {
210209

211210
// If the user's chosen runtime does not have the flux policy enabled, skip this plugin
212-
if info == nil || info.RuntimePolicy.FluxPolicySource == nil {
211+
if info == nil || info.RuntimePolicy.MLPolicySource == nil || info.RuntimePolicy.MLPolicySource.Flux == nil {
213212
return nil, nil
214213
}
215214

pkg/runtime/runtime.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ func WithMLPolicySource(mlPolicy *trainer.MLPolicy) InfoOption {
119119
return func(o *InfoOptions) {
120120
if mlPolicy != nil {
121121
o.runtimePolicy.MLPolicySource = &mlPolicy.MLPolicySource
122-
o.runtimePolicy.FluxPolicySource = mlPolicy.Flux
123122
}
124123
}
125124
}

0 commit comments

Comments
 (0)