Skip to content

Commit 9a17b58

Browse files
committed
cmd-build-with-buildah: drop readling from manifest
We can pickup the stream from the build-args now so let's do that because we are moving more and more stuff out of the manifests themselves.
1 parent a3b297e commit 9a17b58

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/cmd-build-with-buildah

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -122,10 +122,8 @@ build_with_buildah() {
122122
initconfig="src/config.json"
123123
if [ -f "${initconfig}" ]; then
124124
variant="$(jq --raw-output '."coreos-assembler.config-variant"' "${initconfig}")"
125-
manifest="src/config/manifest-${variant}.yaml"
126125
argsfile=build-args-${variant}.conf
127126
else
128-
manifest="src/config/manifest.yaml"
129127
argsfile=build-args.conf
130128
fi
131129

@@ -174,9 +172,9 @@ build_with_buildah() {
174172

175173
# XXX: Temporary hack until we have https://github.com/coreos/rpm-ostree/pull/5454
176174
# which would allow us to fold this back into the build process.
177-
# shellcheck source=/dev/null
178-
stream=$(yaml2json "$manifest" /dev/stdout | jq -r '.variables.stream')
179-
if [ "${stream}" != null ]; then
175+
# shellcheck source=/dev/null disable=SC2153
176+
stream=$(eval "$(grep 'STREAM=' "src/config/${argsfile}")"; echo "${STREAM}")
177+
if [ -n "${stream}" ]; then
180178
set -- "$@" --label fedora-coreos.stream="$stream" \
181179
--annotation fedora-coreos.stream="$stream"
182180
fi

0 commit comments

Comments
 (0)