Skip to content

Commit 02de1ea

Browse files
committed
Add baggage kv check.
Change-Id: I011f93b7ba63f4bae45e0861e408263d23a6bf6f
1 parent 83099bc commit 02de1ea

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

cozeloop/internal/trace/span.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ def to_header(self) -> Dict[str, str]:
559559
def to_header_baggage(self) -> str:
560560
if not self.baggage:
561561
return ""
562-
return ",".join(f"{k}={v}" for k, v in self.baggage().items())
562+
return ",".join(f"{k}={v}" for k, v in self.baggage().items() if k and v)
563563

564564
def to_header_parent(self) -> str:
565565
return f"{GLOBAL_TRACE_VERSION:02x}-{self.trace_id}-{self.span_id}-{self.flags:02x}"
@@ -631,6 +631,9 @@ def parse_comma_separated_map(src: str, cover: bool) -> Dict[str, str]:
631631
key = urllib.parse.unquote(kv[0])
632632
value = urllib.parse.unquote(kv[1])
633633

634+
if not key or not value:
635+
continue
636+
634637
if key not in baggage or cover:
635638
baggage[key] = value
636639

0 commit comments

Comments
 (0)