Skip to content

Commit 220b8b2

Browse files
committed
ping should catch exceptions
1 parent dcf5717 commit 220b8b2

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

cronitor/monitor.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,8 +137,12 @@ def ping(self, **params):
137137
if not self.api_key:
138138
logger.error('No API key detected. Set cronitor.api_key or initialize Monitor with kwarg.')
139139
return
140-
141-
return self._req.get(url=self._ping_api_url(), params=self._clean_params(params), timeout=5, headers=self._headers)
140+
try:
141+
self._req.get(url=self._ping_api_url(), params=self._clean_params(params), timeout=5, headers=self._headers)
142+
return True
143+
except Exception:
144+
logger.error('Failed to ping Cronitor with key - %s' % self.key)
145+
return False
142146

143147
def ok(self):
144148
self.ping(state=cronitor.State.ok)

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
setup(
44
name='cronitor',
5-
version='4.0.0',
5+
version='4.0.1',
66
packages=find_packages(),
77
url='https://github.com/cronitorio/cronitor-python',
88
license='MIT License',

0 commit comments

Comments
 (0)