Fix writting string #24

danielklecha · danielklecha · commit acc3827295ac · 2026-02-05T22:03:41.000+01:00
diff --git a/SharpIpp/Protocol/IppProtocol.Attributes.cs b/SharpIpp/Protocol/IppProtocol.Attributes.cs
@@ -174,8 +174,9 @@ private Resolution ReadResolution(BinaryReader stream)
 
         public void Write(string value, BinaryWriter stream, Encoding? encoding)
         {
-            stream.WriteBigEndian((short)value.Length);
-            stream.Write((encoding ?? Encoding.ASCII).GetBytes(value));
+            var bytes = (encoding ?? Encoding.ASCII).GetBytes(value);
+            stream.WriteBigEndian((short)bytes.Length);
+            stream.Write(bytes);
         }
 
         private string ReadString(BinaryReader stream, Encoding? encoding = null)

Original file line number	Diff line number	Diff line change
`@@ -174,8 +174,9 @@ private Resolution ReadResolution(BinaryReader stream)`
`174`	`174`
`175`	`175`	`public void Write(string value, BinaryWriter stream, Encoding? encoding)`
`176`	`176`	`{`
`177`		`- stream.WriteBigEndian((short)value.Length);`
`178`		`- stream.Write((encoding ?? Encoding.ASCII).GetBytes(value));`
	`177`	`+ var bytes = (encoding ?? Encoding.ASCII).GetBytes(value);`
	`178`	`+ stream.WriteBigEndian((short)bytes.Length);`
	`179`	`+ stream.Write(bytes);`
`179`	`180`	`}`
`180`	`181`
`181`	`182`	`private string ReadString(BinaryReader stream, Encoding? encoding = null)`