feat: make the sizes of the list and preview window configurable

Author: dasvh

README.md

@@ -47,6 +47,7 @@ require('taskfile').setup({
       width = 0.6,
       height = 0.4,
       border = "rounded"
+      width_ratio = 0.4  -- Ratio (0-1) of list vs preview width
     },
   },
   scroll = {

lua/taskfile/core.lua

@@ -15,6 +15,7 @@ local config = {
       width = 0.6,
       height = 0.4,
       border = "rounded",
+      width_ratio = 0.4,
     },
   },
   scroll = {
@@ -77,8 +78,11 @@ end
 ---@field height? number # Height of the window (0–1 for percentage)
 ---@field border? string # Border style (e.g., "single", "rounded")
 
+---@class ListWindowConfig : WindowConfig
+---@field width_ratio? number # Ratio (0–1) of list vs preview width. Default is 0.4
+
 ---@class TaskfileConfig
----@field windows? { output?: WindowConfig, list?: WindowConfig } # Floating window layouts
+---@field windows? { output?: WindowConfig, list?: ListWindowConfig } # Floating window layouts
 ---@field scroll? { auto?: boolean } # Auto-scroll output to the bottom
 ---@field keymaps? { rerun?: string } # Keymap configuration for commands like rerun
 --- Setup the Taskfile plugin
@@ -92,6 +96,14 @@ M.setup = function(opts)
   })
   M._options = vim.tbl_deep_extend("force", {}, config, opts or {})
 
+  utils.validate_range({
+    ["windows.output.width"] = M._options.windows.output.width,
+    ["windows.output.height"] = M._options.windows.output.height,
+    ["windows.list.width"] = M._options.windows.list.width,
+    ["windows.list.height"] = M._options.windows.list.height,
+    ["windows.list.width_ratio"] = M._options.windows.list.width_ratio,
+  }, 0, 1)
+
   if M._options.keymaps ~= false then
     setup_global_keymaps()
   end
@@ -169,7 +181,7 @@ M.close_task_output_window = function()
 end
 
 --- Return the window configuration for the list
----@return WindowConfig
+---@return ListWindowConfig
 M.get_list_config = function()
   return M._options.windows.list
 end

lua/taskfile/ui.lua

@@ -2,6 +2,8 @@
 local M = {}
 local utils = require("taskfile.utils")
 
+local WINDOW_GAP = 2
+
 M._list_win = nil
 M._preview_win = nil
 M._list_buf = nil
@@ -73,7 +75,7 @@ end
 
 --- Opens a floating window with a list of tasks and a preview of the selected task.
 ---@param tasks table List of tasks
----@param config WindowConfig The window config for the preview
+---@param config ListWindowConfig Window Configuration for the list
 M.select_task_with_preview = function(tasks, config)
   if #tasks == 0 then
     vim.notify("No tasks available", vim.log.levels.WARN)
@@ -84,8 +86,9 @@ M.select_task_with_preview = function(tasks, config)
   close_task_list_and_preview()
 
   local total_width, total_height, row, col = utils.calculate_dimensions(config.width, config.height)
-  local list_width = math.floor(total_width * 0.3)
-  local preview_width = total_width - list_width - 2
+  local ratio = config.width_ratio or 0.4
+  local list_width = math.floor(total_width * ratio)
+  local preview_width = total_width - list_width - WINDOW_GAP
 
   M._list_buf = vim.api.nvim_create_buf(false, true)
   M._preview_buf = vim.api.nvim_create_buf(false, true)

lua/taskfile/utils.lua

@@ -58,4 +58,22 @@ M.open_floating_win = function(buf, opts, enter)
   )
 end
 
+--- Validate numeric fields fall within a given range
+---@param t table<string, number|nil>
+---@param min number
+---@param max number
+M.validate_range = function(t, min, max)
+  for name, value in pairs(t) do
+    vim.validate({
+      [name] = {
+        value,
+        function(v)
+          return (v == nil) or ((type(v) == "number") and ((v >= min) and (v <= max)))
+        end,
+        string.format("number between %s and %s", min, max),
+      },
+    })
+  end
+end
+
 return M

tests/taskfile/setup_spec.lua

@@ -64,4 +64,59 @@ describe("setup", function()
     local keymap_cfg = core._options.keymap
     assert.are.same(keymap_cfg.rerun, "<leader>tt")
   end)
+
+  it("should apply valid width_ratio", function()
+    plugin.setup({
+      windows = {
+        list = {
+          width_ratio = 0.9,
+        },
+      },
+    })
+
+    local ratio = core._options.windows.list.width_ratio
+    assert.are.same(0.9, ratio)
+  end)
+
+  it("should raise error for invalid output width < 0", function()
+    local ok, err = pcall(function()
+      plugin.setup({
+        windows = {
+          output = {
+            width = -0.1,
+          },
+        },
+      })
+    end)
+    assert.is_false(ok)
+    assert.matches("output.width", err)
+  end)
+
+  it("should raise error for invalid list height > 1", function()
+    local ok, err = pcall(function()
+      plugin.setup({
+        windows = {
+          list = {
+            height = 1.5,
+          },
+        },
+      })
+    end)
+    assert.is_false(ok)
+    assert.matches("list.height", err)
+  end)
+
+  it("should raise error for invalid width_ratio type", function()
+    local ok, err = pcall(function()
+      plugin.setup({
+        windows = {
+          list = {
+            width_ratio = "wide",
+          },
+        },
+      })
+    end)
+    assert.is_false(ok)
+    assert.matches("width_ratio", err)
+  end)
 end)

tests/taskfile/ui_spec.lua

@@ -134,4 +134,21 @@ tasks:
       ui.select_task_with_preview({})
     end)
   end)
+
+  it("respects width_ratio when calculating window sizes", function()
+    local ratio = 0.5
+    local available_width = 1.0
+    local total_width = math.floor(vim.o.columns * available_width)
+    local expected_list_width = math.floor(total_width * ratio)
+
+    ui.select_task_with_preview(tasks, {
+      width = available_width,
+      height = 0.4,
+      border = "rounded",
+      width_ratio = ratio,
+    })
+
+    local list_win_config = vim.api.nvim_win_get_config(ui._list_win)
+    assert.are.same(expected_list_width, list_win_config.width)
+  end)
 end)